Re: [PATCH V2 1/2] powerpc/powernv: new function to access OPAL msglog

2016-02-10 Thread Andrew Donnellan
On 11/02/16 18:14, Joel Stanley wrote: Looks like you didn't break it much. Congratulations on being the new memcons maintainer! Argh, I forgot the golden rule of kernel development - if you touch it, you own it... :) There's one issue with your error handling. diff --git a/arch/powerpc/p

Re: [PATCH V2 1/2] powerpc/powernv: new function to access OPAL msglog

2016-02-10 Thread Joel Stanley
On Tue, Feb 9, 2016 at 5:47 PM, Andrew Donnellan wrote: > Currently, the OPAL msglog/console buffer is exposed as a sysfs file, with > the sysfs read handler responsible for retrieving the log from the OPAL > buffer. We'd like to be able to use it in xmon as well. > > Refactor the OPAL msglog code

Re: [PATCH V2 1/2] powerpc/powernv: new function to access OPAL msglog

2016-02-10 Thread Stewart Smith
Andrew Donnellan writes: > Currently, the OPAL msglog/console buffer is exposed as a sysfs file, with > the sysfs read handler responsible for retrieving the log from the OPAL > buffer. We'd like to be able to use it in xmon as well. > > Refactor the OPAL msglog code to create a new function, opa

[PATCH V2 1/2] powerpc/powernv: new function to access OPAL msglog

2016-02-08 Thread Andrew Donnellan
Currently, the OPAL msglog/console buffer is exposed as a sysfs file, with the sysfs read handler responsible for retrieving the log from the OPAL buffer. We'd like to be able to use it in xmon as well. Refactor the OPAL msglog code to create a new function, opal_msglog_copy(), that copies to an a