Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-09-04 Thread Baoquan He
Hi Hari, Michael On 08/11/23 at 01:23pm, Hari Bathini wrote: > > > On 10/08/23 8:31 am, Baoquan He wrote: > > On 08/10/23 at 10:06am, Ming Lei wrote: > > > On Thu, Aug 10, 2023 at 09:18:27AM +0800, Baoquan He wrote: > > > > On 08/10/23 at 08:09am, Ming Lei wrote: > > > > > On Wed, Aug 09, 2023

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-11 Thread Christoph Hellwig
On Thu, Aug 10, 2023 at 08:09:27AM +0800, Ming Lei wrote: > 1) some archs support 'nr_cpus=1' for kdump kernel, which is fine, since > num_possible_cpus becomes 1. > > 2) some archs do not support 'nr_cpus=1', and have to rely on > 'max_cpus=1', so num_possible_cpus isn't changed, and kernel just

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-11 Thread Hari Bathini
On 10/08/23 8:31 am, Baoquan He wrote: On 08/10/23 at 10:06am, Ming Lei wrote: On Thu, Aug 10, 2023 at 09:18:27AM +0800, Baoquan He wrote: On 08/10/23 at 08:09am, Ming Lei wrote: On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: I'm starting to sound like a broken record,

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Baoquan He
On 08/10/23 at 10:06am, Ming Lei wrote: > On Thu, Aug 10, 2023 at 09:18:27AM +0800, Baoquan He wrote: > > On 08/10/23 at 08:09am, Ming Lei wrote: > > > On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > > > > I'm starting to sound like a broken record, but we can't just do random

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Ming Lei
On Thu, Aug 10, 2023 at 09:18:27AM +0800, Baoquan He wrote: > On 08/10/23 at 08:09am, Ming Lei wrote: > > On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > > > I'm starting to sound like a broken record, but we can't just do random > > > is_kdump checks, and it's not going to

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Baoquan He
On 08/10/23 at 08:09am, Ming Lei wrote: > On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > > I'm starting to sound like a broken record, but we can't just do random > > is_kdump checks, and it's not going to get better by resending it again and > > again. If kdump kernels

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Ming Lei
On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > I'm starting to sound like a broken record, but we can't just do random > is_kdump checks, and it's not going to get better by resending it again and > again. If kdump kernels limit the number of possible CPUs, it needs to >