[PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread John Rigby
So get_immrbase can function without a device_type = soc property in the soc node. The soc node should really be named immr because it does not include the entire soc, however u-boot currently looks up this node by name for a clock fixup so leave it soc for now. We will change it later after

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Grant Likely
On Tue, Aug 5, 2008 at 2:13 PM, John Rigby [EMAIL PROTECTED] wrote: So get_immrbase can function without a device_type = soc property in the soc node. The soc node should really be named immr because it does not include the entire soc, however u-boot currently looks up this node by name for

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Grant Likely
Oops, forgot to add devicetree-discuss to the cc: list g. On Tue, Aug 5, 2008 at 3:05 PM, Grant Likely [EMAIL PROTECTED] wrote: On Tue, Aug 5, 2008 at 2:13 PM, John Rigby [EMAIL PROTECTED] wrote: So get_immrbase can function without a device_type = soc property in the soc node. The soc node

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Scott Wood
Grant Likely wrote: Is it not sufficient to search the tree for a node with the chip-immr compatible value? I don't think this is the intended use case of aliases. That get's really annoying in code that is meant to deal with multiple chips. I don't think finding the network or serial node

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Grant Likely
On Tue, Aug 5, 2008 at 3:08 PM, Scott Wood [EMAIL PROTECTED] wrote: Grant Likely wrote: Is it not sufficient to search the tree for a node with the chip-immr compatible value? I don't think this is the intended use case of aliases. That get's really annoying in code that is meant to deal

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread John Rigby
Uncle! U-boot: The 5121 currently fixes up the soc's bus-frequency node with a hard coded path. I'll leave it that way. Kernel: I would like to use mpc83xx_add_bridge for 5121. This is why I moved it to fsl_pci.c. It currently uses get_immrbase and adds 0x8300 and 0x8304

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Scott Wood
Grant Likely wrote: But finding nodes that meet a criteria *is* what compatible is for and there is precedence for it. All u-boot platforms are finding the node by path right now, and so all of them need to be changed. Changing them to find by compatible that is set per-board or per-SoC makes

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Scott Wood
John Rigby wrote: I would like to use mpc83xx_add_bridge for 5121. This is why I moved it to fsl_pci.c. It currently uses get_immrbase and adds 0x8300 and 0x8304 to it to pass to setup_indirect_pci as the cfg_addr, and cfg_data addresses. I'm more than willing to change

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread John Rigby
Scott Wood wrote: John Rigby wrote: I would like to use mpc83xx_add_bridge for 5121. This is why I moved it to fsl_pci.c. It currently uses get_immrbase and adds 0x8300 and 0x8304 to it to pass to setup_indirect_pci as the cfg_addr, and cfg_data addresses. I'm more than

Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

2008-08-05 Thread Anton Vorontsov
On Tue, Aug 05, 2008 at 04:19:44PM -0500, Scott Wood wrote: Grant Likely wrote: But finding nodes that meet a criteria *is* what compatible is for and there is precedence for it. All u-boot platforms are finding the node by path right now, and so all of them need to be changed. Changing