Re: [PATCH kernel] cxl: Remove unused include

2018-10-03 Thread Frederic Barrat
Le 03/10/2018 à 09:46, Alexey Kardashevskiy a écrit : On 28/09/2018 22:46, Michael Ellerman wrote: Alexey Kardashevskiy writes: The included opal.h gives a wrong idea that CXL makes PPC OPAL calls while it does not so let's remote it. But it does use eg. OPAL_PHB_CAPI_MODE_SNOOP_ON

Re: [PATCH kernel] cxl: Remove unused include

2018-10-03 Thread Alexey Kardashevskiy
On 28/09/2018 22:46, Michael Ellerman wrote: > Alexey Kardashevskiy writes: >> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls >> while it does not so let's remote it. > > But it does use eg. > > OPAL_PHB_CAPI_MODE_SNOOP_ON > OPAL_PHB_CAPI_MODE_CAPI > > Which come fr

Re: [PATCH kernel] cxl: Remove unused include

2018-09-28 Thread Michael Ellerman
Alexey Kardashevskiy writes: > The included opal.h gives a wrong idea that CXL makes PPC OPAL calls > while it does not so let's remote it. But it does use eg. OPAL_PHB_CAPI_MODE_SNOOP_ON OPAL_PHB_CAPI_MODE_CAPI Which come from opal-api.h via opal.h. So you should at least include opal-api

Re: [PATCH kernel] cxl: Remove unused include

2018-09-28 Thread Andrew Donnellan
On 28/9/18 4:38 pm, Alexey Kardashevskiy wrote: The included opal.h gives a wrong idea that CXL makes PPC OPAL calls while it does not so let's remote it. Signed-off-by: Alexey Kardashevskiy Thanks for catching this Acked-by: Andrew Donnellan --- drivers/misc/cxl/pci.c | 1 - 1 file ch

[PATCH kernel] cxl: Remove unused include

2018-09-27 Thread Alexey Kardashevskiy
The included opal.h gives a wrong idea that CXL makes PPC OPAL calls while it does not so let's remote it. Signed-off-by: Alexey Kardashevskiy --- drivers/misc/cxl/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c index b66d832..8cbcbb7 1006