Re: [PATCH kernel v3] powerpc/book3s64: Fix error handling in mm_iommu_do_alloc()

2020-03-05 Thread Michael Ellerman
On Mon, 2019-12-23 at 06:03:51 UTC, Alexey Kardashevskiy wrote: > The last jump to free_exit in mm_iommu_do_alloc() happens after page > pointers in struct mm_iommu_table_group_mem_t were already converted to > physical addresses. Thus calling put_page() on these physical addresses > will likely

Re: [PATCH kernel v3] powerpc/book3s64: Fix error handling in mm_iommu_do_alloc()

2020-02-18 Thread Michael Ellerman
Alexey Kardashevskiy writes: > On 24/12/2019 10:32, Alexey Kardashevskiy wrote: ... >> >> I could rearrange the code even more but since there is no NVLink3 >> coming ever, I'd avoid changing it more than necessary. Thanks, > > Repost? Rework? I'll just take v3. cheers

Re: [PATCH kernel v3] powerpc/book3s64: Fix error handling in mm_iommu_do_alloc()

2020-02-17 Thread Alexey Kardashevskiy
On 24/12/2019 10:32, Alexey Kardashevskiy wrote: > > > On 23/12/2019 22:18, Michael Ellerman wrote: >> Alexey Kardashevskiy writes: >> >>> The last jump to free_exit in mm_iommu_do_alloc() happens after page >>> pointers in struct mm_iommu_table_group_mem_t were already converted to >>>

Re: [PATCH kernel v3] powerpc/book3s64: Fix error handling in mm_iommu_do_alloc()

2019-12-23 Thread Alexey Kardashevskiy
On 23/12/2019 22:18, Michael Ellerman wrote: > Alexey Kardashevskiy writes: > >> The last jump to free_exit in mm_iommu_do_alloc() happens after page >> pointers in struct mm_iommu_table_group_mem_t were already converted to >> physical addresses. Thus calling put_page() on these physical

Re: [PATCH kernel v3] powerpc/book3s64: Fix error handling in mm_iommu_do_alloc()

2019-12-23 Thread Michael Ellerman
Alexey Kardashevskiy writes: > The last jump to free_exit in mm_iommu_do_alloc() happens after page > pointers in struct mm_iommu_table_group_mem_t were already converted to > physical addresses. Thus calling put_page() on these physical addresses > will likely crash. > > This moves the loop

[PATCH kernel v3] powerpc/book3s64: Fix error handling in mm_iommu_do_alloc()

2019-12-22 Thread Alexey Kardashevskiy
The last jump to free_exit in mm_iommu_do_alloc() happens after page pointers in struct mm_iommu_table_group_mem_t were already converted to physical addresses. Thus calling put_page() on these physical addresses will likely crash. This moves the loop which calculates the pageshift and converts