Re: [PATCH linux-next] drivers/hvc: Add missing of_node_put

2008-12-02 Thread Stephen Rothwell
On Tue, 2 Dec 2008 14:38:55 +0100 Nicolas Palix <[EMAIL PROTECTED]> wrote: > > of_node_put is needed before discarding a value received from > of_find_node_by_name, eg in error handling code or when the device > node is no longer used. > > Signed-off-by: Nicolas Palix <[EMAIL PROTECTED]> > Signed-

[PATCH linux-next] drivers/hvc: Add missing of_node_put

2008-12-02 Thread Nicolas Palix
of_node_put is needed before discarding a value received from of_find_node_by_name, eg in error handling code or when the device node is no longer used. The semantic match that catches the bug is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression struct device_n