On Thu, 16 Jul 2020 13:22:00 -0700
Jakub Kicinski wrote:
> On Thu, 16 Jul 2020 18:07:37 +0200 Michal Suchánek wrote:
> > On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote:
> > > On 7/15/20 8:29 PM, David Miller wrote:
> > > > From: Jakub Kicinski
> > > > Date: Wed, 15 Jul 2020
On Thu, 16 Jul 2020 18:07:37 +0200 Michal Suchánek wrote:
> On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote:
> > On 7/15/20 8:29 PM, David Miller wrote:
> > > From: Jakub Kicinski
> > > Date: Wed, 15 Jul 2020 17:06:32 -0700
> > >
> > > > On Wed, 15 Jul 2020 18:51:55 -0500 Thomas
On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote:
>
> On 7/15/20 8:29 PM, David Miller wrote:
> > From: Jakub Kicinski
> > Date: Wed, 15 Jul 2020 17:06:32 -0700
> >
> > > On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
> > > > free_netdev(netdev);
> > > > dev
On 7/15/20 8:29 PM, David Miller wrote:
From: Jakub Kicinski
Date: Wed, 15 Jul 2020 17:06:32 -0700
On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
free_netdev(netdev);
dev_set_drvdata(&dev->dev, NULL);
+ netdev_info(netdev, "VNIC client device has been successf
From: Jakub Kicinski
Date: Wed, 15 Jul 2020 17:06:32 -0700
> On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
>> free_netdev(netdev);
>> dev_set_drvdata(&dev->dev, NULL);
>> +netdev_info(netdev, "VNIC client device has been successfully
>> removed.\n");
>
> A step too far,
On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
> free_netdev(netdev);
> dev_set_drvdata(&dev->dev, NULL);
> + netdev_info(netdev, "VNIC client device has been successfully
> removed.\n");
A step too far, perhaps.
In general this patch looks a little questionable IMHO, th
Improve the ibmvnic driver's logging capabilities by providing
more informational messages to track driver operations, facilitating
first-pass debug.
Signed-off-by: Thomas Falcon
---
drivers/net/ethernet/ibm/ibmvnic.c | 76 --
1 file changed, 62 insertions(+), 14 dele
