Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-27 Thread Rosen Penev
On Sun, Oct 27, 2024 at 7:32 PM Michael Ellerman wrote: > > Rosen Penev writes: > > On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote: > >> > >> On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: > >> > The latter is the preferred way to copy ethtool strings. > >> > > >> > Avoids manu

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-27 Thread Michael Ellerman
Rosen Penev writes: > On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote: >> >> On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: >> > The latter is the preferred way to copy ethtool strings. >> > >> > Avoids manually incrementing the pointer. Cleans up the code quite well. >> > >> > S

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-26 Thread Simon Horman
On Fri, Oct 25, 2024 at 12:32:27PM -0700, Rosen Penev wrote: > On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote: > > > > On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: > > > The latter is the preferred way to copy ethtool strings. > > > > > > Avoids manually incrementing the pointe

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-25 Thread Rosen Penev
On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote: > > On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: > > The latter is the preferred way to copy ethtool strings. > > > > Avoids manually incrementing the pointer. Cleans up the code quite well. > > > > Signed-off-by: Rosen Penev > >

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-25 Thread Simon Horman
On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: > The latter is the preferred way to copy ethtool strings. > > Avoids manually incrementing the pointer. Cleans up the code quite well. > > Signed-off-by: Rosen Penev ... > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtoo

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-25 Thread kernel test robot
/r/20241024205257.574836-1-rosenp%40gmail.com patch subject: [PATCH net-next] net: freescale: use ethtool string helpers config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241025/202410252249.mme2ezpz-...@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm

[PATCH net-next] net: freescale: use ethtool string helpers

2024-10-24 Thread Rosen Penev
The latter is the preferred way to copy ethtool strings. Avoids manually incrementing the pointer. Cleans up the code quite well. Signed-off-by: Rosen Penev --- .../ethernet/freescale/dpaa/dpaa_ethtool.c| 40 ++- .../ethernet/freescale/dpaa2/dpaa2-ethtool.c | 15 +++ ..