Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885

2022-01-18 Thread Jakub Kicinski
On Mon, 17 Jan 2022 15:00:41 +0100 Andrew Lunn wrote: > > Should I send a v2 even if nothing else > > pops up, or is this more of a if-you're-sending-a-v2-anyway type of > > comment? > > If you reply with a Fixes: patchwork will automagically append it like > it does Reviewed-by, Tested-by etc.

Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885

2022-01-18 Thread Tobias Waldekranz
On Sun, Jan 16, 2022 at 22:15, Tobias Waldekranz wrote: > Once an MDIO read transaction is initiated, we must read back the data > register within 16 MDC cycles after the transaction completes. Outside > of this window, reads may return corrupt data. > > Therefore, disable local interrupts in the

Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885

2022-01-17 Thread Andrew Lunn
On Mon, Jan 17, 2022 at 08:24:22AM +0100, Tobias Waldekranz wrote: > On Sun, Jan 16, 2022 at 23:02, Andrew Lunn wrote: > > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: > >> Once an MDIO read transaction is initiated, we must read back the data > >> register within 16 MDC

Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885

2022-01-16 Thread Tobias Waldekranz
On Sun, Jan 16, 2022 at 23:02, Andrew Lunn wrote: > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: >> Once an MDIO read transaction is initiated, we must read back the data >> register within 16 MDC cycles after the transaction completes. Outside >> of this window, reads may

Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885

2022-01-16 Thread Andrew Lunn
On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: > Once an MDIO read transaction is initiated, we must read back the data > register within 16 MDC cycles after the transaction completes. Outside > of this window, reads may return corrupt data. > > Therefore, disable local

[PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885

2022-01-16 Thread Tobias Waldekranz
Once an MDIO read transaction is initiated, we must read back the data register within 16 MDC cycles after the transaction completes. Outside of this window, reads may return corrupt data. Therefore, disable local interrupts in the critical section, to maximize the probability that we can satisfy