Re: [PATCH v10 09/12] ima: Implement support for module-style appended signatures

2019-05-28 Thread Mimi Zohar
On Tue, 2019-05-28 at 16:23 -0300, Thiago Jung Bauermann wrote: > Mimi Zohar writes: > > > Hi Thiago, > > > >> diff --git a/security/integrity/ima/ima_policy.c > >> b/security/integrity/ima/ima_policy.c > >> index fca7a3f23321..a7a20a8c15c1 100644 > >> --- a/security/integrity/ima/ima_policy.c >

Re: [PATCH v10 09/12] ima: Implement support for module-style appended signatures

2019-05-28 Thread Thiago Jung Bauermann
Mimi Zohar writes: > Hi Thiago, > > On Thu, 2019-04-18 at 00:51 -0300, Thiago Jung Bauermann wrote: >> >> @@ -326,6 +356,10 @@ int ima_appraise_measurement(enum ima_hooks func, >> case INTEGRITY_UNKNOWN: >> break; >> case INTEGRITY_NOXATTRS:/* No EVM protected xattrs. */ >> +/* It's fine not t

Re: [PATCH v10 09/12] ima: Implement support for module-style appended signatures

2019-05-28 Thread Thiago Jung Bauermann
Mimi Zohar writes: > Hi Thiago, > >> diff --git a/security/integrity/ima/ima_policy.c >> b/security/integrity/ima/ima_policy.c >> index fca7a3f23321..a7a20a8c15c1 100644 >> --- a/security/integrity/ima/ima_policy.c >> +++ b/security/integrity/ima/ima_policy.c >> @@ -1144,6 +1144,12 @@ void ima

Re: [PATCH v10 09/12] ima: Implement support for module-style appended signatures

2019-05-14 Thread Mimi Zohar
Hi Thiago, On Thu, 2019-04-18 at 00:51 -0300, Thiago Jung Bauermann wrote: > > @@ -326,6 +356,10 @@ int ima_appraise_measurement(enum ima_hooks func, > case INTEGRITY_UNKNOWN: > break; > case INTEGRITY_NOXATTRS:/* No EVM protected xattrs. */ > +

Re: [PATCH v10 09/12] ima: Implement support for module-style appended signatures

2019-05-09 Thread Mimi Zohar
Hi Thiago, > diff --git a/security/integrity/ima/ima_policy.c > b/security/integrity/ima/ima_policy.c > index fca7a3f23321..a7a20a8c15c1 100644 > --- a/security/integrity/ima/ima_policy.c > +++ b/security/integrity/ima/ima_policy.c > @@ -1144,6 +1144,12 @@ void ima_delete_rules(void) > } >

[PATCH v10 09/12] ima: Implement support for module-style appended signatures

2019-04-17 Thread Thiago Jung Bauermann
Implement the appraise_type=imasig|modsig option, allowing IMA to read and verify modsig signatures. In case a file has both an xattr signature and an appended modsig, IMA will only use the appended signature if the key used by the xattr signature isn't present in the IMA or platform keyring. Bec