Re: [PATCH v10 5/9] ima: make process_buffer_measurement() generic

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:30 UTC, Mimi Zohar wrote: > From: Nayna Jain > > process_buffer_measurement() is limited to measuring the kexec boot > command line. This patch makes process_buffer_measurement() more > generic, allowing it to measure other types of buffer data (e.g. > blacklisted bina

Re: [PATCH v10 5/9] ima: make process_buffer_measurement() generic

2019-10-31 Thread Lakshmi Ramasubramanian
On 10/31/19 10:02 AM, Lakshmi Ramasubramanian wrote: On 10/30/19 8:31 PM, Mimi Zohar wrote:   void ima_kexec_cmdline(const void *buf, int size)   { -    u32 secid; - -    if (buf && size != 0) { -    security_task_getsecid(current, &secid); +    if (buf && size != 0) Open brace { is miss

Re: [PATCH v10 5/9] ima: make process_buffer_measurement() generic

2019-10-31 Thread Lakshmi Ramasubramanian
On 10/30/19 8:31 PM, Mimi Zohar wrote: void ima_kexec_cmdline(const void *buf, int size) { - u32 secid; - - if (buf && size != 0) { - security_task_getsecid(current, &secid); + if (buf && size != 0) Open brace { is missing in the above if statement.

[PATCH v10 5/9] ima: make process_buffer_measurement() generic

2019-10-30 Thread Mimi Zohar
From: Nayna Jain process_buffer_measurement() is limited to measuring the kexec boot command line. This patch makes process_buffer_measurement() more generic, allowing it to measure other types of buffer data (e.g. blacklisted binary hashes or key hashes). process_buffer_measurement() may be cal