What email client are you using, I have never seen this type of
formatting, and it makes it impossible to read your replies. Please
resolve this.
Wrong prefix setting. Should be fixed now.
Sometimes people miss things on previous reviews, this is not a perfict
system, only the best that we
On Tue, Oct 25, 2011 at 2:54 PM, Tirumala Marri tma...@apm.com wrote:
Overall this driver seems to be based on the IP vendor driver? It
looks like a completely flexible driver that implements all possible
combinations of everything.
[Tirumala Marri] Some what true that it was based on
No, just start over from scratch. Just leave the crap driver behind,
use it for reference but write the new one.
It's obvious given that you are already at iteration v15 and it's
still looking this bad that this is not realistic to get reviewed and
accepted as-is. I don't think staging is a good
Greg,
No, just start over from scratch. Just leave the crap driver behind,
use it for reference but write the new one.
It's obvious given that you are already at iteration v15 and it's
still looking this bad that this is not realistic to get reviewed and
accepted as-is. I don't think staging is
Hi Marri,
On Wed, 2011-10-26 at 09:06 -0700, Tirumala Marri wrote:
No, just start over from scratch. Just leave the crap driver behind,
use it for reference but write the new one.
It's obvious given that you are already at iteration v15 and it's
still looking this bad that this is not
On Wed, Oct 26, 2011 at 10:17:19AM -0700, Tirumala Marri wrote:
Greg,
No, just start over from scratch. Just leave the crap driver behind,
use it for reference but write the new one.
What email client are you using, I have never seen this type of
formatting, and it makes it impossible to
On Sun, Oct 23, 2011 at 2:00 AM, Olof Johansson o...@lixom.net wrote:
Hi,
On Fri, Oct 21, 2011 at 10:33 AM, Olof Johansson o...@lixom.net wrote:
On Fri, Oct 14, 2011 at 03:08:34PM -0700, tma...@apm.com wrote:
From: Tirumala Marri tma...@apm.com
Overall this driver seems to be based on
Overall this driver seems to be based on the IP vendor driver? It
looks like a completely flexible driver that implements all possible
combinations of everything.
[Tirumala Marri] Some what true that it was based on skeletal driver
Provided from IP vendor.
And as a result, it's huge, and it's
Hi Pratyush,
Hi Tirumala,
I have reviwed all the patches.
Thanks for taking my most of the diffs over your v13.
There are few thing, which are really very important like,
AHB disable check, EP Disable/Stall (have commented about them in
respective patches). I am doubtful, that how does all of
Hi,
On Fri, Oct 21, 2011 at 10:33 AM, Olof Johansson o...@lixom.net wrote:
On Fri, Oct 14, 2011 at 03:08:34PM -0700, tma...@apm.com wrote:
From: Tirumala Marri tma...@apm.com
Overall this driver seems to be based on the IP vendor driver? It
looks like a completely flexible driver that
On Fri, Oct 14, 2011 at 03:08:34PM -0700, tma...@apm.com wrote:
From: Tirumala Marri tma...@apm.com
Overall this driver seems to be based on the IP vendor driver? It
looks like a completely flexible driver that implements all possible
combinations of everything.
And as a result, it's huge, and
Hi Tirumala,
I have reviwed all the patches.
Thanks for taking my most of the diffs over your v13.
There are few thing, which are really very important like,
AHB disable check, EP Disable/Stall (have commented about them in
respective patches). I am doubtful, that how does all of usbcv test cases
From: Tirumala Marri tma...@apm.com
v15:
1. Fixed some checkpatch errors.
2. Added spin lock check during read-modify-write of interrupt registers
out side intr handlers.
3. Removed Kconfig var which is not used and not defined.
v14:
1. Modifying dwc_reg_read/write functions to accepts
13 matches
Mail list logo
