Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-27 Thread Dan Williams
On Wed, Sep 24, 2008 at 2:59 PM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Modify the Freescale Elo / Elo Plus DMA driver so that it can be compiled as > a module. > > The primary change is to stop treating the DMA controller as a bus, and the > DMA channels as devices on the bus. This is because th

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Scott Wood
Timur Tabi wrote: Scott Wood wrote: I chose subsys_initcall() to increase the probability that fsldma is already present when DMA clients are loaded/initialized and register. If there's no dependency, why does it matter whether fsldma is already present? Re-read my explanation, please. I r

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
Scott Wood wrote: >> I chose subsys_initcall() to increase the probability that fsldma is >> already present when DMA clients are loaded/initialized and register. > > If there's no dependency, why does it matter whether fsldma is already > present? Re-read my explanation, please. Technically,

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Scott Wood
Timur Tabi wrote: There are no dependencies. fsldma registers with the DMA engine, which is always built in-kernel. The DMA engine is what handles linking DMA clients to DMA drivers. The DMA clients get a callback whenever a DMA driver registers with the DMA engine. If the DMA driver is alread

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
On Thu, Sep 25, 2008 at 1:40 PM, Scott Wood <[EMAIL PROTECTED]> wrote: > If there's a dependency there, how will it work when this is built as a > module? There are no dependencies. fsldma registers with the DMA engine, which is always built in-kernel. The DMA engine is what handles linking DMA

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Scott Wood
On Thu, Sep 25, 2008 at 08:54:30AM -0500, Timur Tabi wrote: > Li Yang wrote: > > >> -subsys_initcall(of_fsl_dma_chan_init); > >> subsys_initcall(of_fsl_dma_init); > > > > Not a critical problem. But module_init() are preferred for modules. > > This was intentional. When compiled as a module,

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
Li Yang wrote: >> -subsys_initcall(of_fsl_dma_chan_init); >> subsys_initcall(of_fsl_dma_init); > > Not a critical problem. But module_init() are preferred for modules. This was intentional. When compiled as a module, subsys_initcall becomes module_init(). When compiled in-kernel, this code i

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-24 Thread Li Yang
On Thu, Sep 25, 2008 at 5:59 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Modify the Freescale Elo / Elo Plus DMA driver so that it can be compiled as > a module. > > The primary change is to stop treating the DMA controller as a bus, and the > DMA channels as devices on the bus. This is because th

[PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-24 Thread Timur Tabi
Modify the Freescale Elo / Elo Plus DMA driver so that it can be compiled as a module. The primary change is to stop treating the DMA controller as a bus, and the DMA channels as devices on the bus. This is because the Open Firmware (OF) kernel code does not allow busses to be removed, so althoug