Re: [PATCH v2] libnvdimm/pmem: Fix blk_cleanup_disk() usage

2021-06-08 Thread Jens Axboe
On 6/7/21 5:52 PM, Dan Williams wrote: > The queue_to_disk() helper can not be used after del_gendisk() > communicate @disk via the pgmap->owner. > > Otherwise, queue_to_disk() returns NULL resulting in the splat below. > > Kernel attempted to read user page (330) - exploit attempt? (uid: 0) >

Re: [PATCH v2] libnvdimm/pmem: Fix blk_cleanup_disk() usage

2021-06-07 Thread Sachin Sant
> Reported-by: Sachin Sant > Fixes: 87eb73b2ca7c ("nvdimm-pmem: convert to > blk_alloc_disk/blk_cleanup_disk") > Link: > http://lore.kernel.org/r/dfb75ba8-603f-4a35-880b-c5b23ef8f...@linux.vnet.ibm.com > Cc: Christoph Hellwig > Cc: Ulf Hansson > Cc: Jens Axboe > Signed-off-by: Dan Williams

Re: [PATCH v2] libnvdimm/pmem: Fix blk_cleanup_disk() usage

2021-06-07 Thread Christoph Hellwig
Thanks Dan, this looks good to me: Reviewed-by: Christoph Hellwig Jens, can you quickly pick this up?

[PATCH v2] libnvdimm/pmem: Fix blk_cleanup_disk() usage

2021-06-07 Thread Dan Williams
The queue_to_disk() helper can not be used after del_gendisk() communicate @disk via the pgmap->owner. Otherwise, queue_to_disk() returns NULL resulting in the splat below. Kernel attempted to read user page (330) - exploit attempt? (uid: 0) BUG: Kernel NULL pointer dereference on read at