Re: [PATCH v2] scsi: sg: Avoid race in error handling & drop bogus warn

2024-04-01 Thread Alexander Wetzel
On 01.04.24 19:09, Bart Van Assche wrote: On 4/1/24 03:03, Alexander Wetzel wrote: commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") introduced an incorrect WARN_ON_ONCE() and missed a sequence where sg_device_destroy() was used after scsi_device_put(). Isn't that too negative? I

Re: [PATCH v2] scsi: sg: Avoid race in error handling & drop bogus warn

2024-04-01 Thread Bart Van Assche
On 4/1/24 03:03, Alexander Wetzel wrote: commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") introduced an incorrect WARN_ON_ONCE() and missed a sequence where sg_device_destroy() was used after scsi_device_put(). Isn't that too negative? I think that the WARN_ON_ONCE() mentioned ab

[PATCH v2] scsi: sg: Avoid race in error handling & drop bogus warn

2024-04-01 Thread Alexander Wetzel
commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") introduced an incorrect WARN_ON_ONCE() and missed a sequence where sg_device_destroy() was used after scsi_device_put(). sg_device_destroy() is accessing the parent scsi_device request_queue which will already be set to NULL when the