Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Waiman Long
On 12/6/23 16:02, Waiman Long wrote: On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, On 12/4/23 19:05, George Stark wrote: Using of devm API leads to certain order of

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread George Stark
On 12/7/23 16:01, Christophe Leroy wrote: Le 07/12/2023 à 13:51, George Stark a écrit : On 12/7/23 15:28, Christophe Leroy wrote: Le 07/12/2023 à 13:02, Andy Shevchenko a écrit : On Thu, Dec 7, 2023 at 1:23 AM George Stark wrote: On 12/7/23 01:37, Christophe Leroy wrote: Le

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Christophe Leroy
Le 07/12/2023 à 13:51, George Stark a écrit : > > > On 12/7/23 15:28, Christophe Leroy wrote: >> >> >> Le 07/12/2023 à 13:02, Andy Shevchenko a écrit : >>> On Thu, Dec 7, 2023 at 1:23 AM George Stark >>> wrote: On 12/7/23 01:37, Christophe Leroy wrote: > Le 06/12/2023 à 23:14,

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread George Stark
On 12/7/23 15:28, Christophe Leroy wrote: Le 07/12/2023 à 13:02, Andy Shevchenko a écrit : On Thu, Dec 7, 2023 at 1:23 AM George Stark wrote: On 12/7/23 01:37, Christophe Leroy wrote: Le 06/12/2023 à 23:14, Christophe Leroy a écrit : ... Looking at it closer, I have the feeling that

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Andy Shevchenko
On Thu, Dec 7, 2023 at 2:31 PM Christophe Leroy wrote: > Le 07/12/2023 à 12:59, Andy Shevchenko a écrit : > > On Thu, Dec 7, 2023 at 1:23 AM George Stark > > wrote: > >> On 12/7/23 01:37, Christophe Leroy wrote: > >>> Le 06/12/2023 à 23:14, Christophe Leroy a écrit : > Le 06/12/2023 à

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Christophe Leroy
Le 07/12/2023 à 12:59, Andy Shevchenko a écrit : > On Thu, Dec 7, 2023 at 1:23 AM George Stark wrote: >> On 12/7/23 01:37, Christophe Leroy wrote: >>> Le 06/12/2023 à 23:14, Christophe Leroy a écrit : Le 06/12/2023 à 19:58, George Stark a écrit : > On 12/6/23 18:01, Hans de Goede

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Christophe Leroy
Le 07/12/2023 à 13:02, Andy Shevchenko a écrit : > On Thu, Dec 7, 2023 at 1:23 AM George Stark wrote: >> On 12/7/23 01:37, Christophe Leroy wrote: >>> Le 06/12/2023 à 23:14, Christophe Leroy a écrit : > > ... > >>> Looking at it closer, I have the feeling that you want to do similar to >>>

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Andy Shevchenko
On Thu, Dec 7, 2023 at 1:23 AM George Stark wrote: > On 12/7/23 01:37, Christophe Leroy wrote: > > Le 06/12/2023 à 23:14, Christophe Leroy a écrit : ... > > Looking at it closer, I have the feeling that you want to do similar to > > devm_gpio_request() in linux/gpio.h : > > > > In

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-07 Thread Andy Shevchenko
On Thu, Dec 7, 2023 at 1:23 AM George Stark wrote: > On 12/7/23 01:37, Christophe Leroy wrote: > > Le 06/12/2023 à 23:14, Christophe Leroy a écrit : > >> Le 06/12/2023 à 19:58, George Stark a écrit : > >>> On 12/6/23 18:01, Hans de Goede wrote: > On 12/4/23 19:05, George Stark wrote: ... >

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Waiman Long
On 12/6/23 19:37, George Stark wrote: Hello Waiman Thanks for the review. On 12/7/23 00:02, Waiman Long wrote: On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, ...

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread George Stark
Hello Waiman Thanks for the review. On 12/7/23 00:02, Waiman Long wrote: On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, ... mutex_destroy() only actually does anything

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread George Stark
Hello Christophe On 12/7/23 01:37, Christophe Leroy wrote: Le 06/12/2023 à 23:14, Christophe Leroy a écrit : Le 06/12/2023 à 19:58, George Stark a écrit : [Vous ne recevez pas souvent de courriers de gnst...@salutedevices.com. Découvrez pourquoi ceci est important à

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Christophe Leroy
Le 06/12/2023 à 23:14, Christophe Leroy a écrit : > > > Le 06/12/2023 à 19:58, George Stark a écrit : >> [Vous ne recevez pas souvent de courriers de >> gnst...@salutedevices.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> Hello Hans >>

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Christophe Leroy
Le 06/12/2023 à 19:58, George Stark a écrit : > [Vous ne recevez pas souvent de courriers de gnst...@salutedevices.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Hello Hans > > Thanks for the review. > > On 12/6/23 18:01, Hans de Goede

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Hans de Goede
Hi, On 12/6/23 19:58, George Stark wrote: > > Hello Hans > > Thanks for the review. > > On 12/6/23 18:01, Hans de Goede wrote: >> Hi George, >> >> On 12/4/23 19:05, George Stark wrote: >>> Using of devm API leads to certain order of releasing resources. >>> So all dependent resources which are

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Hans de Goede
Hi George, On 12/4/23 19:05, George Stark wrote: > Using of devm API leads to certain order of releasing resources. > So all dependent resources which are not devm-wrapped should be deleted > with respect to devm-release order. Mutex is one of such objects that > often is bound to other resources

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Hans de Goede
Hi, On 12/6/23 08:56, George Stark wrote: > Hello Andy > > Thanks for the review. > > On 12/4/23 21:11, Andy Shevchenko wrote: >> On Mon, Dec 4, 2023 at 8:07 PM George Stark >> wrote: >>> >>> Using of devm API leads to certain order of releasing resources. >>> So all dependent resources which

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Waiman Long
On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, On 12/4/23 19:05, George Stark wrote: Using of devm API leads to certain order of releasing resources. So all dependent

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread George Stark
Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, On 12/4/23 19:05, George Stark wrote: Using of devm API leads to certain order of releasing resources. So all dependent resources which are not devm-wrapped should be deleted with respect to devm-release

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-05 Thread George Stark
Hello Andy Thanks for the review. On 12/4/23 21:11, Andy Shevchenko wrote: On Mon, Dec 4, 2023 at 8:07 PM George Stark wrote: Using of devm API leads to certain order of releasing resources. So all dependent resources which are not devm-wrapped should be deleted with respect to devm-release

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-05 Thread Matti Vaittinen
On 12/4/23 20:05, George Stark wrote: Using of devm API leads to certain order of releasing resources. So all dependent resources which are not devm-wrapped should be deleted with respect to devm-release order. Mutex is one of such objects that often is bound to other resources and has no own

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-04 Thread Christophe Leroy
Le 04/12/2023 à 19:05, George Stark a écrit : > Using of devm API leads to certain order of releasing resources. > So all dependent resources which are not devm-wrapped should be deleted > with respect to devm-release order. Mutex is one of such objects that > often is bound to other resources

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-04 Thread Andy Shevchenko
On Mon, Dec 4, 2023 at 8:07 PM George Stark wrote: > > Using of devm API leads to certain order of releasing resources. > So all dependent resources which are not devm-wrapped should be deleted > with respect to devm-release order. Mutex is one of such objects that > often is bound to other

[PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-04 Thread George Stark
Using of devm API leads to certain order of releasing resources. So all dependent resources which are not devm-wrapped should be deleted with respect to devm-release order. Mutex is one of such objects that often is bound to other resources and has no own devm wrapping. Since mutex_destroy()