Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-16 Thread Valentin Schneider
On 16/08/21 16:03, Srikar Dronamraju wrote: >> >> Your version is much much better than mine. >> And I have verified that it works as expected. >> >> > > Hey Peter/Valentin > > Are we waiting for any more feedback/testing for this? > I'm not overly fond of that last one, but AFAICT the only

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-16 Thread Srikar Dronamraju
> > Your version is much much better than mine. > And I have verified that it works as expected. > > Hey Peter/Valentin Are we waiting for any more feedback/testing for this? -- Thanks and Regards Srikar Dronamraju

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-10 Thread Srikar Dronamraju
* Valentin Schneider [2021-08-09 13:52:38]: > On 09/08/21 12:22, Srikar Dronamraju wrote: > > * Valentin Schneider [2021-08-08 16:56:47]: > >> Wait, doesn't the distance matrix (without any offline node) say > >> > >> distance(0, 3) == 40 > >> > >> ? We should have at the very least: > >> >

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-09 Thread Valentin Schneider
On 09/08/21 12:22, Srikar Dronamraju wrote: > * Valentin Schneider [2021-08-08 16:56:47]: >> Wait, doesn't the distance matrix (without any offline node) say >> >> distance(0, 3) == 40 >> >> ? We should have at the very least: >> >> node 0 1 2 3 >> 0: 10 20 ?? 40 >> 1: 20

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-09 Thread Srikar Dronamraju
* Valentin Schneider [2021-08-08 16:56:47]: > > A bit late, but technically the week isn't over yet! :D > > On 23/07/21 20:09, Srikar Dronamraju wrote: > > * Valentin Schneider [2021-07-13 17:32:14]: > >> Now, let's take examples from your cover letter: > >> > >> node distances: > >> node

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-08 Thread Valentin Schneider
A bit late, but technically the week isn't over yet! :D On 23/07/21 20:09, Srikar Dronamraju wrote: > * Valentin Schneider [2021-07-13 17:32:14]: >> Now, let's take examples from your cover letter: >> >> node distances: >> node 0 1 2 3 4 5 6 7 >> 0: 10 20 40 40 40

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-04 Thread Valentin Schneider
On 04/08/21 15:31, Srikar Dronamraju wrote: > * Srikar Dronamraju [2021-07-23 20:09:14]: > >> * Valentin Schneider [2021-07-13 17:32:14]: >> >> > On 12/07/21 18:18, Srikar Dronamraju wrote: >> > > Hi Valentin, >> > > >> > >> On 01/07/21 09:45, Srikar Dronamraju wrote: >> > >> > @@ -1891,12

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-08-04 Thread Srikar Dronamraju
* Srikar Dronamraju [2021-07-23 20:09:14]: > * Valentin Schneider [2021-07-13 17:32:14]: > > > On 12/07/21 18:18, Srikar Dronamraju wrote: > > > Hi Valentin, > > > > > >> On 01/07/21 09:45, Srikar Dronamraju wrote: > > >> > @@ -1891,12 +1894,30 @@ void sched_init_numa(void) > > >> > void

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-07-23 Thread Srikar Dronamraju
* Valentin Schneider [2021-07-13 17:32:14]: > On 12/07/21 18:18, Srikar Dronamraju wrote: > > Hi Valentin, > > > >> On 01/07/21 09:45, Srikar Dronamraju wrote: > >> > @@ -1891,12 +1894,30 @@ void sched_init_numa(void) > >> > void sched_domains_numa_masks_set(unsigned int cpu) > >> > { > > > >

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-07-13 Thread Valentin Schneider
On 12/07/21 18:18, Srikar Dronamraju wrote: > Hi Valentin, > >> On 01/07/21 09:45, Srikar Dronamraju wrote: >> > @@ -1891,12 +1894,30 @@ void sched_init_numa(void) >> > void sched_domains_numa_masks_set(unsigned int cpu) >> > { >> >> Hmph, so we're playing games with masks of offline nodes - is

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-07-12 Thread Srikar Dronamraju
Hi Valentin, > On 01/07/21 09:45, Srikar Dronamraju wrote: > > @@ -1891,12 +1894,30 @@ void sched_init_numa(void) > > void sched_domains_numa_masks_set(unsigned int cpu) > > { > > Hmph, so we're playing games with masks of offline nodes - is that really > necessary? Your modification of

Re: [PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-07-01 Thread Valentin Schneider
On 01/07/21 09:45, Srikar Dronamraju wrote: > @@ -1891,12 +1894,30 @@ void sched_init_numa(void) > void sched_domains_numa_masks_set(unsigned int cpu) > { > int node = cpu_to_node(cpu); > - int i, j; > + int i, j, empty; > > + empty =

[PATCH v2 1/2] sched/topology: Skip updating masks for non-online nodes

2021-06-30 Thread Srikar Dronamraju
Currently scheduler doesn't check if node is online before adding CPUs to the node mask. However on some architectures, node distance is only available for nodes that are online. Its not sure how much to rely on the node distance, when one of the nodes is offline. If said node distance is fake