Re: [PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a function

2017-04-19 Thread 'Naveen N. Rao'
On 2017/04/19 08:48AM, David Laight wrote: > From: Naveen N. Rao > > Sent: 19 April 2017 09:09 > > To: David Laight; Michael Ellerman > > Cc: linux-ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Masami > > Hiramatsu; Ingo Molnar > > Subject: RE

RE: [PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a function

2017-04-19 Thread David Laight
From: Naveen N. Rao > Sent: 19 April 2017 09:09 > To: David Laight; Michael Ellerman > Cc: linux-ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Masami > Hiramatsu; Ingo Molnar > Subject: RE: [PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a > function >

RE: [PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a function

2017-04-19 Thread Naveen N. Rao
Excerpts from David Laight's message of April 18, 2017 18:22: From: Naveen N. Rao Sent: 12 April 2017 11:58 ... +kprobe_opcode_t *kprobe_lookup_name(const char *name) +{ ... + char dot_name[MODULE_NAME_LEN + 1 + KSYM_NAME_LEN]; + const char *modsym; + bool dot_appended =

RE: [PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a function

2017-04-18 Thread David Laight
From: Naveen N. Rao > Sent: 12 April 2017 11:58 ... > +kprobe_opcode_t *kprobe_lookup_name(const char *name) > +{ ... > + char dot_name[MODULE_NAME_LEN + 1 + KSYM_NAME_LEN]; > + const char *modsym; > + bool dot_appended = false; > + if ((modsym = strchr(name, ':')) != NULL) { > +

Re: [PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a function

2017-04-12 Thread Masami Hiramatsu
On Wed, 12 Apr 2017 16:28:24 +0530 "Naveen N. Rao" wrote: > The macro is now pretty long and ugly on powerpc. In the light of > further changes needed here, convert it to a __weak variant to be > over-ridden with a nicer looking function. Looks good to me.

[PATCH v2 1/5] kprobes: convert kprobe_lookup_name() to a function

2017-04-12 Thread Naveen N. Rao
The macro is now pretty long and ugly on powerpc. In the light of further changes needed here, convert it to a __weak variant to be over-ridden with a nicer looking function. Suggested-by: Masami Hiramatsu Signed-off-by: Naveen N. Rao ---