[PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-07-26 Thread Herve Codina
Introduce the qmc_chan_setup_tsa* functions to setup entries related to the given channel. Use them during QMC channels setup. Signed-off-by: Herve Codina --- drivers/soc/fsl/qe/qmc.c | 161 ++- 1 file changed, 125 insertions(+), 36 deletions(-) diff --git a/

Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-08-01 Thread Andrew Lunn
> +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set) > +{ > + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set); > +} > + Please don't use inline in .c files. Let the compiler decide. Andrew

Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-08-01 Thread Herve Codina
On Tue, 1 Aug 2023 11:36:43 +0200 Andrew Lunn wrote: > > +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set) > > +{ > > + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set); > > +} > > + > > Please don't use inline in .c files. Let the compiler decide. > >Andr

Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

2023-08-08 Thread Christophe Leroy
Le 26/07/2023 à 17:02, Herve Codina a écrit : > Introduce the qmc_chan_setup_tsa* functions to setup entries related > to the given channel. > Use them during QMC channels setup. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > drivers/soc/fsl/qe/qmc.c | 161 ++