Re: [PATCH v2 11/30] cxlflash: Make functions static

2015-09-21 Thread Matthew R. Ochs
> On Sep 21, 2015, at 7:18 AM, Tomas Henzl wrote: > On 16.9.2015 23:28, Matthew R. Ochs wrote: >> >> + >> +write_rrin: >> +nretry = 0; >> +writeq_be(rrin, &afu->host_map->ioarrin); >> +do { >> +rrin = readq_be(&afu->host_map->ioarrin); >> +if (rrin != 0x1) >> +

Re: [PATCH v2 11/30] cxlflash: Make functions static

2015-09-21 Thread Tomas Henzl
On 16.9.2015 23:28, Matthew R. Ochs wrote: > Found during code inspection, that the following functions are not > being used outside of the file where they are defined. Make them static. > > int cxlflash_send_cmd(struct afu *, struct afu_cmd *); > void cxlflash_wait_resp(struct afu *, struct afu_cm

Re: [PATCH v2 11/30] cxlflash: Make functions static

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v2 11/30] cxlflash: Make functions static

2015-09-16 Thread Matthew R. Ochs
Found during code inspection, that the following functions are not being used outside of the file where they are defined. Make them static. int cxlflash_send_cmd(struct afu *, struct afu_cmd *); void cxlflash_wait_resp(struct afu *, struct afu_cmd *); int cxlflash_afu_reset(struct cxlflash_cfg *);

[PATCH v2 11/30] cxlflash: Make functions static

2015-09-16 Thread Matthew R. Ochs
Found during code inspection, that the following functions are not being used outside of the file where they are defined. Make them static. int cxlflash_send_cmd(struct afu *, struct afu_cmd *); void cxlflash_wait_resp(struct afu *, struct afu_cmd *); int cxlflash_afu_reset(struct cxlflash_cfg *);