Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-18 Thread Michael Ellerman
Rob Herring writes: > On Tue, Dec 18, 2018 at 2:33 PM Frank Rowand wrote: >> >> On 12/18/18 12:09 PM, Frank Rowand wrote: >> > On 12/18/18 12:01 PM, Rob Herring wrote: >> >> On Tue, Dec 18, 2018 at 12:57 PM Frank Rowand >> >> wrote: >> >>> >> >>> On 12/17/18 2:52 AM, Michael Ellerman wrote: >>

Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-18 Thread Rob Herring
On Tue, Dec 18, 2018 at 2:33 PM Frank Rowand wrote: > > On 12/18/18 12:09 PM, Frank Rowand wrote: > > On 12/18/18 12:01 PM, Rob Herring wrote: > >> On Tue, Dec 18, 2018 at 12:57 PM Frank Rowand > >> wrote: > >>> > >>> On 12/17/18 2:52 AM, Michael Ellerman wrote: > Hi Frank, > > fr

Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-18 Thread Frank Rowand
On 12/18/18 12:09 PM, Frank Rowand wrote: > On 12/18/18 12:01 PM, Rob Herring wrote: >> On Tue, Dec 18, 2018 at 12:57 PM Frank Rowand wrote: >>> >>> On 12/17/18 2:52 AM, Michael Ellerman wrote: Hi Frank, frowand.l...@gmail.com writes: > From: Frank Rowand > > Non-overla

Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-18 Thread Frank Rowand
On 12/18/18 12:01 PM, Rob Herring wrote: > On Tue, Dec 18, 2018 at 12:57 PM Frank Rowand wrote: >> >> On 12/17/18 2:52 AM, Michael Ellerman wrote: >>> Hi Frank, >>> >>> frowand.l...@gmail.com writes: From: Frank Rowand Non-overlay dynamic devicetree node removal may leave the node

Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-18 Thread Rob Herring
On Tue, Dec 18, 2018 at 12:57 PM Frank Rowand wrote: > > On 12/17/18 2:52 AM, Michael Ellerman wrote: > > Hi Frank, > > > > frowand.l...@gmail.com writes: > >> From: Frank Rowand > >> > >> Non-overlay dynamic devicetree node removal may leave the node in > >> the phandle cache. Subsequent calls

Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-18 Thread Frank Rowand
On 12/17/18 2:52 AM, Michael Ellerman wrote: > Hi Frank, > > frowand.l...@gmail.com writes: >> From: Frank Rowand >> >> Non-overlay dynamic devicetree node removal may leave the node in >> the phandle cache. Subsequent calls to of_find_node_by_phandle() >> will incorrectly find the stale entry.

Re: [PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-17 Thread Michael Ellerman
Hi Frank, frowand.l...@gmail.com writes: > From: Frank Rowand > > Non-overlay dynamic devicetree node removal may leave the node in > the phandle cache. Subsequent calls to of_find_node_by_phandle() > will incorrectly find the stale entry. Remove the node from the > cache. > > Add paranoia chec

[PATCH v2 2/2] of: __of_detach_node() - remove node from phandle cache

2018-12-17 Thread frowand . list
From: Frank Rowand Non-overlay dynamic devicetree node removal may leave the node in the phandle cache. Subsequent calls to of_find_node_by_phandle() will incorrectly find the stale entry. Remove the node from the cache. Add paranoia checks in of_find_node_by_phandle() as a second level of def