Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-27 Thread Daniel Borkmann
On 06/27/2014 07:08 AM, Michael Ellerman wrote: On Thu, 2014-06-26 at 10:36 +0200, Daniel Borkmann wrote: On 06/26/2014 10:30 AM, Michael Ellerman wrote: On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote: We have to return the boolean here if the tag presents or not, not just ANDing the

Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-27 Thread David Miller
From: Denis Kirjanov k...@linux-powerpc.org Date: Wed, 25 Jun 2014 21:34:57 +0400 We have to return the boolean here if the tag presents or not, not just ANDing the TCI with the mask which results to: [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT [ 709.412245] ret 4096 != 1 [

Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-26 Thread Michael Ellerman
On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote: We have to return the boolean here if the tag presents or not, not just ANDing the TCI with the mask which results to: [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT [ 709.412245] ret 4096 != 1 [ 709.412332] ret 4096 != 1 [

Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-26 Thread Daniel Borkmann
On 06/26/2014 10:30 AM, Michael Ellerman wrote: On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote: We have to return the boolean here if the tag presents or not, not just ANDing the TCI with the mask which results to: [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT [ 709.412245] ret

Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-26 Thread Denis Kirjanov
On 6/26/14, Michael Ellerman m...@ellerman.id.au wrote: On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote: We have to return the boolean here if the tag presents or not, not just ANDing the TCI with the mask which results to: [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT [

Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-26 Thread Michael Ellerman
On Thu, 2014-06-26 at 10:36 +0200, Daniel Borkmann wrote: On 06/26/2014 10:30 AM, Michael Ellerman wrote: On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote: We have to return the boolean here if the tag presents or not, not just ANDing the TCI with the mask which results to: [

[PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-25 Thread Denis Kirjanov
We have to return the boolean here if the tag presents or not, not just ANDing the TCI with the mask which results to: [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT [ 709.412245] ret 4096 != 1 [ 709.412332] ret 4096 != 1 [ 709.412333] FAIL (2 times) Signed-off-by: Denis Kirjanov