Re: [PATCH v2 4/9] powerpc/powernv: OPAL console standardise OPAL_BUSY loops

2018-04-09 Thread Benjamin Herrenschmidt
On Mon, 2018-04-09 at 16:13 +1000, Nicholas Piggin wrote: > We can always make exceptions to the standard form, but in those > cases I would like to document it in the OPAL API and comment for > the Linux side. > > My thinking in this case is that it reduces time in firmware and > in particular ho

Re: [PATCH v2 4/9] powerpc/powernv: OPAL console standardise OPAL_BUSY loops

2018-04-08 Thread Nicholas Piggin
On Mon, 09 Apr 2018 15:53:33 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2018-04-09 at 15:24 +1000, Nicholas Piggin wrote: > > Convert to using the standard delay poll/delay form. > > > > The console code: > > > > - Did not previously delay or sleep in its busy loop. > > > > Cc: Benjamin Her

Re: [PATCH v2 4/9] powerpc/powernv: OPAL console standardise OPAL_BUSY loops

2018-04-08 Thread Benjamin Herrenschmidt
On Mon, 2018-04-09 at 15:24 +1000, Nicholas Piggin wrote: > Convert to using the standard delay poll/delay form. > > The console code: > > - Did not previously delay or sleep in its busy loop. > > Cc: Benjamin Herrenschmidt > Signed-off-by: Nicholas Piggin Does it help with anything ? We don'

[PATCH v2 4/9] powerpc/powernv: OPAL console standardise OPAL_BUSY loops

2018-04-08 Thread Nicholas Piggin
Convert to using the standard delay poll/delay form. The console code: - Did not previously delay or sleep in its busy loop. Cc: Benjamin Herrenschmidt Signed-off-by: Nicholas Piggin --- arch/powerpc/platforms/powernv/opal.c | 38 --- 1 file changed, 23 insertions(+),