Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-23 Thread Balbir Singh
On Fri, 22 Jan 2016 22:54:44 +0100 Ard Biesheuvel wrote: > > """ > kallsyms: add support for relative offsets in kallsyms address table > > Similar to how relative extables are implemented, it is possible to emit > the kallsyms table in such a way that it contains

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-22 Thread Andrew Morton
On Fri, 22 Jan 2016 09:20:41 +0100 Ard Biesheuvel wrote: > > : in half since offsets can typically be expressed in 32 bits. > > : > """ > > In addition to fixing the broken grammar, would it make sense to > mention that dynamic relocation only occurs under >

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-22 Thread Ard Biesheuvel
On 22 January 2016 at 22:07, Andrew Morton wrote: > On Fri, 22 Jan 2016 09:20:41 +0100 Ard Biesheuvel > wrote: > >> > : in half since offsets can typically be expressed in 32 bits. >> > : >> """ >> >> In addition to fixing the broken

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-22 Thread Ard Biesheuvel
On 22 January 2016 at 00:20, Andrew Morton wrote: > On Thu, 21 Jan 2016 14:55:00 -0800 Kees Cook wrote: > >> IIUC, this means that the relocation work done after decompression now >> doesn't have to do relocation updates for all these values,

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-22 Thread Andrew Morton
On Thu, 21 Jan 2016 18:19:43 +0100 Ard Biesheuvel wrote: > Similar to how relative extables are implemented, it is possible to emit > the kallsyms table in such a way that it contains offsets relative to some > anchor point in the kernel image rather than absolute

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-22 Thread Andrew Morton
On Fri, 22 Jan 2016 15:34:28 -0800 Andrew Morton wrote: > > Support for the above is enabled by default for all architectures except > > IA-64, whose symbols are too far apart to capture in this manner. > > scripts/kallsyms.c: In function 'record_relative_base': >

[PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-21 Thread Ard Biesheuvel
Similar to how relative extables are implemented, it is possible to emit the kallsyms table in such a way that it contains offsets relative to some anchor point in the kernel image rather than absolute addresses. The benefit is that such table entries are no longer subject to dynamic relocation

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-21 Thread Kees Cook
On Thu, Jan 21, 2016 at 2:50 PM, Andrew Morton wrote: > On Thu, 21 Jan 2016 18:19:43 +0100 Ard Biesheuvel > wrote: > >> Similar to how relative extables are implemented, it is possible to emit >> the kallsyms table in such a way that it

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-21 Thread Andrew Morton
On Thu, 21 Jan 2016 14:55:00 -0800 Kees Cook wrote: > IIUC, this means that the relocation work done after decompression now > doesn't have to do relocation updates for all these values, which > means a smaller relocation table as well. Makes sense, thanks. I altered the

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-21 Thread Andrew Morton
On Thu, 21 Jan 2016 18:19:43 +0100 Ard Biesheuvel wrote: > Similar to how relative extables are implemented, it is possible to emit > the kallsyms table in such a way that it contains offsets relative to some > anchor point in the kernel image rather than absolute

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-21 Thread Michael Ellerman
On Thu, 2016-01-21 at 14:55 -0800, Kees Cook wrote: > On Thu, Jan 21, 2016 at 2:50 PM, Andrew Morton > wrote: > > On Thu, 21 Jan 2016 18:19:43 +0100 Ard Biesheuvel > > wrote: > > > > > Similar to how relative extables are implemented, it is

Re: [PATCH v3] kallsyms: add support for relative offsets in kallsyms address table

2016-01-21 Thread Ard Biesheuvel
On 22 January 2016 at 04:44, Michael Ellerman wrote: > On Thu, 2016-01-21 at 14:55 -0800, Kees Cook wrote: >> On Thu, Jan 21, 2016 at 2:50 PM, Andrew Morton >> wrote: >> > On Thu, 21 Jan 2016 18:19:43 +0100 Ard Biesheuvel >> >