Re: [PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-13 Thread Nicholas Piggin
Daniel Axtens's on March 11, 2020 9:03 am: So: - change the test when setting up a PACA to consider the actual value of the MSR rather than the CPU feature. - move the PACA setup to before the cpu feature parsing. >>> >>> Hmm. Problem is that equally we want PACA to

Re: [PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-10 Thread Daniel Axtens
>>> So: >>> - change the test when setting up a PACA to consider the actual value of >>>the MSR rather than the CPU feature. >>> >>> - move the PACA setup to before the cpu feature parsing. >> >> Hmm. Problem is that equally we want PACA to be sane before we call too >> far into the rest of

Re: [PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-10 Thread Michael Ellerman
Nicholas Piggin writes: > Daniel Axtens's on March 6, 2020 5:30 pm: >> kcov instrumentation is collected the __sanitizer_cov_trace_pc hook in >> kernel/kcov.c. The compiler inserts these hooks into every basic block >> unless kcov is disabled for that file. >> >> We then have a deep call-chain:

Re: [PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-06 Thread Nicholas Piggin
Daniel Axtens's on March 6, 2020 5:30 pm: > kcov instrumentation is collected the __sanitizer_cov_trace_pc hook in > kernel/kcov.c. The compiler inserts these hooks into every basic block > unless kcov is disabled for that file. > > We then have a deep call-chain: > - __sanitizer_cov_trace_pc

Re: [PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-06 Thread Daniel Axtens
Andrew Donnellan writes: > On 6/3/20 6:30 pm, Daniel Axtens wrote: >> kcov instrumentation is collected the __sanitizer_cov_trace_pc hook in >> kernel/kcov.c. The compiler inserts these hooks into every basic block >> unless kcov is disabled for that file. >> >> We then have a deep call-chain:

Re: [PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-06 Thread Andrew Donnellan
On 6/3/20 6:30 pm, Daniel Axtens wrote: kcov instrumentation is collected the __sanitizer_cov_trace_pc hook in kernel/kcov.c. The compiler inserts these hooks into every basic block unless kcov is disabled for that file. We then have a deep call-chain: - __sanitizer_cov_trace_pc calls to

[PATCH v3] powerpc: setup_64: set up PACA earlier to avoid kcov problems

2020-03-05 Thread Daniel Axtens
kcov instrumentation is collected the __sanitizer_cov_trace_pc hook in kernel/kcov.c. The compiler inserts these hooks into every basic block unless kcov is disabled for that file. We then have a deep call-chain: - __sanitizer_cov_trace_pc calls to check_kcov_mode() - check_kcov_mode()