Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Marc Kleine-Budde
On 06/23/2014 10:15 AM, qiang.z...@freescale.com wrote: [...] > + reg_esr = flexcan_read(®s->esr); > + reg_ctrl = flexcan_read(®s->ctrl); > + if (reg_esr & FLEXCAN_ESR_TX_WRN) { When does the hardware trigger the interrupt? >>> >>> When there is no wire link between tx and rx,

RE: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread qiang.z...@freescale.com
od Scott-B07421 > Subject: Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan > > On 06/23/2014 09:26 AM, qiang.z...@freescale.com wrote: > > > > On 06/23/2014 03:18 PM, Marc Kleine-Budde wrote: > > > >> > >> On 06/23/2014 09:11 AM, Zhao Qiang

Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Marc Kleine-Budde
On 06/23/2014 09:26 AM, qiang.z...@freescale.com wrote: > > On 06/23/2014 03:18 PM, Marc Kleine-Budde wrote: > >> >> On 06/23/2014 09:11 AM, Zhao Qiang wrote: >>> when flexcan is not physically linked, command 'cantest' will trigger >>> an err_irq, add err_irq handler for it. >>> >>> Signed-off-b

RE: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread qiang.z...@freescale.com
On 06/23/2014 03:18 PM, Marc Kleine-Budde wrote: > > On 06/23/2014 09:11 AM, Zhao Qiang wrote: > > when flexcan is not physically linked, command 'cantest' will trigger > > an err_irq, add err_irq handler for it. > > > > Signed-off-by: Zhao Qiang > > --- > > Changes for v2: > > - use a spac

Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Marc Kleine-Budde
On 06/23/2014 09:11 AM, Zhao Qiang wrote: > when flexcan is not physically linked, command 'cantest' will > trigger an err_irq, add err_irq handler for it. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - use a space instead of tab > - use flexcan_poll_state instead of print

[PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Zhao Qiang
when flexcan is not physically linked, command 'cantest' will trigger an err_irq, add err_irq handler for it. Signed-off-by: Zhao Qiang --- Changes for v2: - use a space instead of tab - use flexcan_poll_state instead of print Changes for v3: - return IRQ_HANDLED if err is