Re: [PATCH v3 12/12] Add /proc interface to control topology updates

2013-04-23 Thread Nathan Fontenot
On 04/22/2013 09:49 PM, Michael Ellerman wrote: > On Tue, Apr 23, 2013 at 12:00:26PM +1000, Stephen Rothwell wrote: >> Hi Nathan, >> >> On Mon, 22 Apr 2013 13:47:55 -0500 Nathan Fontenot >> wrote: >>> >>> #if defined(CONFIG_NUMA) && defined(CONFIG_PPC_SPLPAR) >>> extern int start_topology_updat

Re: [PATCH v3 12/12] Add /proc interface to control topology updates

2013-04-22 Thread Michael Ellerman
On Tue, Apr 23, 2013 at 12:00:26PM +1000, Stephen Rothwell wrote: > Hi Nathan, > > On Mon, 22 Apr 2013 13:47:55 -0500 Nathan Fontenot > wrote: > > > > #if defined(CONFIG_NUMA) && defined(CONFIG_PPC_SPLPAR) > > extern int start_topology_update(void); > > extern int stop_topology_update(void);

Re: [PATCH v3 12/12] Add /proc interface to control topology updates

2013-04-22 Thread Stephen Rothwell
Hi Nathan, On Mon, 22 Apr 2013 13:47:55 -0500 Nathan Fontenot wrote: > > +inline int prrn_is_enabled(void) > +{ > + return prrn_enabled; > +} We generally leave these "inline"s up to the compiler these days i.e. remove the "inline". -- Cheers, Stephen Rothwells...@canb

Re: [PATCH v3 12/12] Add /proc interface to control topology updates

2013-04-22 Thread Stephen Rothwell
Hi Nathan, On Mon, 22 Apr 2013 13:47:55 -0500 Nathan Fontenot wrote: > > #if defined(CONFIG_NUMA) && defined(CONFIG_PPC_SPLPAR) > extern int start_topology_update(void); > extern int stop_topology_update(void); > +extern inline int prrn_is_enabled(void); You really can't do "extern inline" w

[PATCH v3 12/12] Add /proc interface to control topology updates

2013-04-22 Thread Nathan Fontenot
There are instances in which we do not want topology updates to occur. In order to allow this a /proc interface (/proc/powerpc/topology_updates) is introduced so that topology updates can be enabled and disabled. This patch also adds a prrn_is_enabled() call so that PRRN events are handled in the