Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Aneesh Kumar K.V
On 10/17/18 4:42 PM, Christophe Leroy wrote: On 10/17/2018 10:32 AM, Michael Ellerman wrote: Christophe Leroy writes: On 10/17/2018 12:59 AM, Michael Ellerman wrote: ... The question is what's the right way to fix it? Should pte_pgprot() not be filtering those bits out on book3e? I think

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Christophe Leroy
On 10/17/2018 10:32 AM, Michael Ellerman wrote: Christophe Leroy writes: On 10/17/2018 12:59 AM, Michael Ellerman wrote: ... The question is what's the right way to fix it? Should pte_pgprot() not be filtering those bits out on book3e? I think we should not use pte_pggrot() for that then

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Michael Ellerman
Christophe Leroy writes: > On 10/17/2018 12:59 AM, Michael Ellerman wrote: ... >> The question is what's the right way to fix it? Should pte_pgprot() not >> be filtering those bits out on book3e? > > I think we should not use pte_pggrot() for that then. What about the > below fix ? Thanks, that

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Christophe LEROY
Le 17/10/2018 à 11:39, Aneesh Kumar K.V a écrit : Christophe Leroy writes: On 10/17/2018 12:59 AM, Michael Ellerman wrote: Christophe Leroy writes: Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separate

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-17 Thread Aneesh Kumar K.V
Christophe Leroy writes: > On 10/17/2018 12:59 AM, Michael Ellerman wrote: >> Christophe Leroy writes: >> >>> Get rid of platform specific _PAGE_ in powerpc common code and >>> use helpers instead. >>> >>> mm/dump_linuxpagetables.c will be handled separately >>> >>> Reviewed-by: Aneesh Kuma

Re: Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Christophe Leroy
On 10/17/2018 12:59 AM, Michael Ellerman wrote: Christophe Leroy writes: Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/

Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Michael Ellerman
Christophe Leroy writes: > Get rid of platform specific _PAGE_ in powerpc common code and > use helpers instead. > > mm/dump_linuxpagetables.c will be handled separately > > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/book3s/32/pgtable.h

[PATCH v3 12/24] powerpc/mm: use pte helpers in generic code

2018-10-09 Thread Christophe Leroy
Get rid of platform specific _PAGE_ in powerpc common code and use helpers instead. mm/dump_linuxpagetables.c will be handled separately Reviewed-by: Aneesh Kumar K.V Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 9 +++-- arch/powerpc/include/asm/n