Re: [PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-25 Thread Brian King
On 09/24/2015 02:44 PM, Matthew R. Ochs wrote: > @@ -1293,8 +1291,8 @@ static int cxlflash_disk_attach(struct scsi_device > *sdev, > > int fd = -1; > > - /* On first attach set fileops */ > - if (atomic_read(>num_user_contexts) == 0) > + /* On very first attach set fileops for

Re: [PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-25 Thread Matthew R. Ochs
> On Sep 25, 2015, at 4:23 PM, Brian King wrote: > On 09/24/2015 02:44 PM, Matthew R. Ochs wrote: >> @@ -1293,8 +1291,8 @@ static int cxlflash_disk_attach(struct scsi_device >> *sdev, >> >> int fd = -1; >> >> -/* On first attach set fileops */ >> -if

[PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-24 Thread Matthew R. Ochs
The fops owned by the adapter can be corrupted in certain scenarios, opening a window where certain fops are temporarily NULLed before being reset to their proper value. This can potentially lead software to make incorrect decisions, leaving the user with the inability to function as intended. An