Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

2024-02-22 Thread Herve Codina
On Thu, 22 Feb 2024 15:19:11 +0200 Andy Shevchenko wrote: > On Thu, Feb 22, 2024 at 01:05:16PM +0100, Herve Codina wrote: > > On Mon, 12 Feb 2024 14:22:56 +0200 > > Andy Shevchenko wrote: > > ... > > > > > +#include > > > > +#include > > > > +#include > > > > > > > +#include > > >

Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

2024-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2024 at 01:05:16PM +0100, Herve Codina wrote: > On Mon, 12 Feb 2024 14:22:56 +0200 > Andy Shevchenko wrote: ... > > > +#include > > > +#include > > > +#include > > > > > +#include > > > +#include > > > > I do not see how these are being used, am I right? > > What's is

Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

2024-02-22 Thread Herve Codina
Hi Andy, On Mon, 12 Feb 2024 14:22:56 +0200 Andy Shevchenko wrote: ... > > > +#include > > +#include > > +#include > > > +#include > > +#include > > I do not see how these are being used, am I right? > What's is missing OTOH is the mod_devicetable.h. Agree for removing of.h and of_

Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

2024-02-12 Thread Andy Shevchenko
On Mon, Feb 12, 2024 at 08:56:29AM +0100, Herve Codina wrote: > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. ... > +#include > +#include > +#include > +#include > +#include I do not see how these are being used, am

[PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

2024-02-11 Thread Herve Codina
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by: Jakub Kicinski --- drivers/net/wan/Kconfig| 12 + drivers/net/wan/Makefile | 1 + drivers/