Re:Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-17 Thread Liang He
在 2022-06-17 18:57:36，"Christophe Leroy" 写道： > > >Le 17/06/2022 à 12:47, Liang He a écrit : >> >> >> >> At 2022-06-17 16:27:03, conor.doo...@microchip.com wrote: >>> On 17/06/2022 09:17, Liang He wrote: At 2022-06-17 14:53:13, "Christophe Leroy" wrote: > >

Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-17 Thread Christophe Leroy
Le 17/06/2022 à 12:47, Liang He a écrit : > > > > At 2022-06-17 16:27:03, conor.doo...@microchip.com wrote: >> On 17/06/2022 09:17, Liang He wrote: >>> >>> >>> >>> At 2022-06-17 14:53:13, "Christophe Leroy" >>> wrote: Le 17/06/2022 à 08:45, Liang He a écrit : > > >

Re:Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-17 Thread Liang He
At 2022-06-17 16:27:03, conor.doo...@microchip.com wrote: >On 17/06/2022 09:17, Liang He wrote: >> >> >> >> At 2022-06-17 14:53:13, "Christophe Leroy" >> wrote: >>> >>> >>> Le 17/06/2022 à 08:45, Liang He a écrit : At 2022-06-17 14:28:56, "Christophe Leroy" wrote:

Re:Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-17 Thread Liang He
At 2022-06-17 16:27:03, conor.doo...@microchip.com wrote: >On 17/06/2022 09:17, Liang He wrote: >> >> >> >> At 2022-06-17 14:53:13, "Christophe Leroy" >> wrote: >>> >>> >>> Le 17/06/2022 à 08:45, Liang He a écrit : At 2022-06-17 14:28:56, "Christophe Leroy" wrote: >

Re:Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-17 Thread Liang He
At 2022-06-17 14:53:13, "Christophe Leroy" wrote: > > >Le 17/06/2022 à 08:45, Liang He a écrit : >> >> >> >> At 2022-06-17 14:28:56, "Christophe Leroy" >> wrote: >>> >>> >>> Le 17/06/2022 à 08:08, Liang He a écrit : In gpio_halt_probe(), of_find_matching_node() will return a node

Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-16 Thread Christophe Leroy
Le 17/06/2022 à 08:45, Liang He a écrit : > > > > At 2022-06-17 14:28:56, "Christophe Leroy" > wrote: >> >> >> Le 17/06/2022 à 08:08, Liang He a écrit : >>> In gpio_halt_probe(), of_find_matching_node() will return a node >>> pointer with refcount incremented. We should use of_node_put() in

Re:Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-16 Thread Liang He
At 2022-06-17 14:28:56, "Christophe Leroy" wrote: > > >Le 17/06/2022 à 08:08, Liang He a écrit : >> In gpio_halt_probe(), of_find_matching_node() will return a node >> pointer with refcount incremented. We should use of_node_put() in >> fail path or when it is not used anymore. >> >> Signed-of

Re: [PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-16 Thread Christophe Leroy
Le 17/06/2022 à 08:08, Liang He a écrit : > In gpio_halt_probe(), of_find_matching_node() will return a node > pointer with refcount incremented. We should use of_node_put() in > fail path or when it is not used anymore. > > Signed-off-by: Liang He > --- > changelog: > v4: reuse exist 'err'

[PATCH v4] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-06-16 Thread Liang He
In gpio_halt_probe(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He --- changelog: v4: reuse exist 'err' and use a simple code style, advised by CJ v3: use local 'ch