RE: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-06 Thread Leo Li
ger.kernel.org; Maxim Kochetkov > ; kernel test robot ; Dan Carpenter > > Subject: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to > platform_device > > Since 5.13 QE's ucc nodes can't get interrupts from devicetree: > > ucc@2000 { >

Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-06 Thread Saravana Kannan
On Thu, Aug 5, 2021 at 9:35 PM Maxim Kochetkov wrote: > > 03.08.2021 20:51, Saravana Kannan wrote: > >> So lets convert this driver to simple platform_device with probe(). > >> Also use platform_get_ and devm_ family function to get/allocate > >> resources and drop unused .compatible = "qeic". > >

Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-06 Thread Maxim Kochetkov
03.08.2021 20:51, Saravana Kannan wrote: So lets convert this driver to simple platform_device with probe(). Also use platform_get_ and devm_ family function to get/allocate resources and drop unused .compatible = "qeic". Yes, please! Should I totally drop { .type = "qeic"}, or keep?

Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-05 Thread Christophe Leroy
Le 06/08/2021 à 06:39, Saravana Kannan a écrit : On Thu, Aug 5, 2021 at 9:35 PM Maxim Kochetkov wrote: 03.08.2021 20:51, Saravana Kannan wrote: So lets convert this driver to simple platform_device with probe(). Also use platform_get_ and devm_ family function to get/allocate resources and

Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-03 Thread Saravana Kannan
On Tue, Aug 3, 2021 at 4:33 AM Maxim Kochetkov wrote: > > Since 5.13 QE's ucc nodes can't get interrupts from devicetree: > > ucc@2000 { > cell-index = <1>; > reg = <0x2000 0x200>; > interrupts = <32>; > interrupt-parent = <&q

[PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-03 Thread Maxim Kochetkov
Since 5.13 QE's ucc nodes can't get interrupts from devicetree: ucc@2000 { cell-index = <1>; reg = <0x2000 0x200>; interrupts = <32>; interrupt-parent = <&qeic>; }; Now fw_devlink expects driver to create and probe a