Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-21 Thread Caleb Crome
On Wed, Dec 20, 2017 at 3:40 AM, Arnaud Mouiche wrote: > > > On 19/12/2017 01:25, Caleb Crome wrote: > >> On Mon, Dec 18, 2017 at 3:02 PM, Nicolin Chen >> wrote: >> >>> On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote: >>> >>> Acked-by: Timur Tabi > --- To Mark --- >>> >>> M

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-21 Thread Nicolin Chen
On Thu, Dec 21, 2017 at 08:10:07AM -0800, Caleb Crome wrote: > >>> the mainline tree, I would like to treat this mail as a separate > >>> > >>> bug report and fix it with a separate patch. > warn: 11a0 11a1 1160 11a3 11a4 11a5 11a6 11a7 > > warn: Valid frame after 1 invalid frame

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-21 Thread Caleb Crome
On Thu, Dec 21, 2017 at 8:08 AM, Caleb Crome wrote: On Wed, Dec 20, 2017 at 3:40 AM, Arnaud Mouiche wrote: > > > > On 19/12/2017 01:25, Caleb Crome wrote: > >> On Mon, Dec 18, 2017 at 3:02 PM, Nicolin Chen wrote: >>> >>> On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote: >>> >>>

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-20 Thread Nicolin Chen
On Wed, Dec 20, 2017 at 12:40:37PM +0100, Arnaud Mouiche wrote: > >>>Ugh, so it's basically quite broken again -- before these patches. > >>I remember Arnaud reviewed one of my changes back to September. > >>So I suppose the test should be fine at that time -- so a change > >>being merged recently

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-20 Thread Arnaud Mouiche
On 19/12/2017 01:25, Caleb Crome wrote: On Mon, Dec 18, 2017 at 3:02 PM, Nicolin Chen wrote: On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote: Acked-by: Timur Tabi --- To Mark --- Mark, can you still take these changes first? Since this failed test that Caleb reported here is

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-18 Thread Caleb Crome
On Mon, Dec 18, 2017 at 3:02 PM, Nicolin Chen wrote: > On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote: > >> > Acked-by: Timur Tabi > > --- To Mark --- > > Mark, can you still take these changes first? Since this failed > test that Caleb reported here is already existing on the top of

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-18 Thread Nicolin Chen
On Mon, Dec 18, 2017 at 02:19:08PM -0800, Caleb Crome wrote: > > Acked-by: Timur Tabi --- To Mark --- Mark, can you still take these changes first? Since this failed test that Caleb reported here is already existing on the top of the mainline tree, I would like to treat this mail as a separate

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-18 Thread Caleb Crome
On Sun, Dec 17, 2017 at 7:13 PM, Timur Tabi wrote: > > On 12/17/17 8:51 PM, Nicolin Chen wrote: >> >> Nicolin Chen (11): >>ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi >>ASoC: fsl_ssi: Cache pdev->dev pointer >>ASoC: fsl_ssi: Refine all comments >>ASoC: fsl_ssi: Rename register

Re: [PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-17 Thread Timur Tabi
On 12/17/17 8:51 PM, Nicolin Chen wrote: Nicolin Chen (11): ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi ASoC: fsl_ssi: Cache pdev->dev pointer ASoC: fsl_ssi: Refine all comments ASoC: fsl_ssi: Rename registers and fields macros ASoC: fsl_ssi: Refine indentations and wrappings

[PATCH v4 00/11] ASoC: fsl_ssi: Clean up - coding style level

2017-12-17 Thread Nicolin Chen
==Changelog== v3->v4 * Revised PATCH-03 "Refine all comments" by adding Timur's inputs * Rebased all other patches v2->v3 * Added Tested-by and Reviewed-by from Maciej * Revised PATCH-03 "Refine all comments" by adding Maciej's advice * Revised PATCH-05 "Refine indentations and wrappings" * R