Re: [PATCH v4 02/32] cxlflash: Replace magic numbers with literals

2015-09-28 Thread Andrew Donnellan
On 26/09/15 09:12, Matthew R. Ochs wrote: From: Manoj Kumar Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs Signed-off-

[PATCH v4 02/32] cxlflash: Replace magic numbers with literals

2015-09-25 Thread Matthew R. Ochs
From: Manoj Kumar Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King