Re: [PATCH v4 03/10] net/ps3_gelic: Format cleanups

2021-08-04 Thread Christophe Leroy
Le 23/07/2021 à 22:31, Geoff Levand a écrit : In an effort to make the PS3 gelic driver easier to maintain, cleanup the the driver source file formatting to be more consistent. WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()

Re: [PATCH v4 03/10] net/ps3_gelic: Format cleanups

2021-07-24 Thread Christophe Leroy
Geoff Levand a écrit : In an effort to make the PS3 gelic driver easier to maintain, cleanup the the driver source file formatting to be more consistent. Many of your changes in this patch go in the wrong direction. For instance, you shall not use { } in an if/else sequence with single

[PATCH v4 03/10] net/ps3_gelic: Format cleanups

2021-07-23 Thread Geoff Levand
In an effort to make the PS3 gelic driver easier to maintain, cleanup the the driver source file formatting to be more consistent. Signed-off-by: Geoff Levand --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 379 ++- 1 file changed, 193 insertions(+), 186 deletions(-) diff