Re: [PATCH v4 04/10] net/ps3_gelic: Add new macro BUG_ON_DEBUG

2021-08-04 Thread Christophe Leroy
Le 23/07/2021 à 22:31, Geoff Levand a écrit : Add a new preprocessor macro BUG_ON_DEBUG, that expands to BUG_ON when the preprocessor macro DEBUG is defined, or to WARN_ON when DEBUG is not defined. Also, replace all occurrences of BUG_ON with BUG_ON_DEBUG. CHECK:MACRO_ARG_REUSE: Macro arg

Re: [PATCH v4 04/10] net/ps3_gelic: Add new macro BUG_ON_DEBUG

2021-07-25 Thread Christophe Leroy
Geoff Levand a écrit : Add a new preprocessor macro BUG_ON_DEBUG, that expands to BUG_ON when the preprocessor macro DEBUG is defined, or to WARN_ON when DEBUG is not defined. Also, replace all occurrences of BUG_ON with BUG_ON_DEBUG. Why is BUG_ON() needed at all if WARN_ON() is enough ? Y

[PATCH v4 04/10] net/ps3_gelic: Add new macro BUG_ON_DEBUG

2021-07-23 Thread Geoff Levand
Add a new preprocessor macro BUG_ON_DEBUG, that expands to BUG_ON when the preprocessor macro DEBUG is defined, or to WARN_ON when DEBUG is not defined. Also, replace all occurrences of BUG_ON with BUG_ON_DEBUG. Signed-off-by: Geoff Levand --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 13 +