Re: [PATCH v4 1/5] net: wan: Add support for QMC HDLC

2024-02-22 Thread Herve Codina
Andy, Jakub, On Thu, 22 Feb 2024 18:56:26 +0200 Andy Shevchenko wrote: > On Thu, Feb 22, 2024 at 05:45:01PM +0100, Herve Codina wrote: > > On Thu, 22 Feb 2024 17:29:05 +0200 > > Andy Shevchenko wrote: > > > On Thu, Feb 22, 2024 at 03:22:14PM +0100, Herve Codina wrote: > > ... > > > > > +

Re: [PATCH v4 1/5] net: wan: Add support for QMC HDLC

2024-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2024 at 05:45:01PM +0100, Herve Codina wrote: > On Thu, 22 Feb 2024 17:29:05 +0200 > Andy Shevchenko wrote: > > On Thu, Feb 22, 2024 at 03:22:14PM +0100, Herve Codina wrote: ... > > > + spin_lock_irqsave(_hdlc->tx_lock, flags); > > > > Why not using cleanup.h from day 1? > >

Re: [PATCH v4 1/5] net: wan: Add support for QMC HDLC

2024-02-22 Thread Herve Codina
On Thu, 22 Feb 2024 17:29:05 +0200 Andy Shevchenko wrote: > On Thu, Feb 22, 2024 at 03:22:14PM +0100, Herve Codina wrote: > > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > > Multichannel Controller) to transfer the HDLC data. > > ... > > > +struct qmc_hdlc { > > +

Re: [PATCH v4 1/5] net: wan: Add support for QMC HDLC

2024-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2024 at 03:22:14PM +0100, Herve Codina wrote: > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. ... > +struct qmc_hdlc { > + struct device *dev; > + struct qmc_chan *qmc_chan; > + struct

[PATCH v4 1/5] net: wan: Add support for QMC HDLC

2024-02-22 Thread Herve Codina
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by: Jakub Kicinski --- drivers/net/wan/Kconfig| 12 + drivers/net/wan/Makefile | 1 +