[PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-19 Thread Jordan Niethe
For powerpc64, redefine the ppc_inst type so both word and prefixed instructions can be represented. On powerpc32 the type will remain the same. Update places which had assumed instructions to be 4 bytes long. Signed-off-by: Jordan Niethe --- v4: New to series --- arch/powerpc/include/asm/code-

Re: [PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-23 Thread Nicholas Piggin
Jordan Niethe's on March 20, 2020 3:18 pm: > For powerpc64, redefine the ppc_inst type so both word and prefixed > instructions can be represented. On powerpc32 the type will remain the > same. Update places which had assumed instructions to be 4 bytes long. > > Signed-off-by: Jordan Niethe > --

Re: [PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-23 Thread Nicholas Piggin
Jordan Niethe's on March 20, 2020 3:18 pm: > For powerpc64, redefine the ppc_inst type so both word and prefixed > instructions can be represented. On powerpc32 the type will remain the > same. Update places which had assumed instructions to be 4 bytes long. > > Signed-off-by: Jordan Niethe > --

Re: [PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-23 Thread Jordan Niethe
On Mon, Mar 23, 2020 at 6:37 PM Nicholas Piggin wrote: > > Jordan Niethe's on March 20, 2020 3:18 pm: > > For powerpc64, redefine the ppc_inst type so both word and prefixed > > instructions can be represented. On powerpc32 the type will remain the > > same. Update places which had assumed instru

Re: [PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-23 Thread Nicholas Piggin
Jordan Niethe's on March 24, 2020 9:45 am: > On Mon, Mar 23, 2020 at 6:37 PM Nicholas Piggin wrote: >> >> Jordan Niethe's on March 20, 2020 3:18 pm: >> I'm a bit against using partially constructed opaque type for things >> like this, even if it is in the code that knows about the type. We >> coul

Re: [PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-30 Thread Alistair Popple
> @@ -487,12 +487,13 @@ int kprobe_post_handler(struct pt_regs *regs) > { > struct kprobe *cur = kprobe_running(); > struct kprobe_ctlblk *kcb = get_kprobe_ctlblk(); > + int len = ppc_inst_len(ppc_inst_read(cur->ainsn.insn)); I am no kprobes expert but it seems based on the code

Re: [PATCH v4 14/16] powerpc64: Add prefixed instructions to instruction data type

2020-03-30 Thread Jordan Niethe
On Mon, Mar 30, 2020 at 8:05 PM Alistair Popple wrote: > > > > > @@ -487,12 +487,13 @@ int kprobe_post_handler(struct pt_regs *regs) > > { > > struct kprobe *cur = kprobe_running(); > > struct kprobe_ctlblk *kcb = get_kprobe_ctlblk(); > > + int len = ppc_inst_len(ppc_inst_read(cu