Re: [PATCH v4 5/5] net: wan: fsl_qmc_hdlc: Add framer support

2024-02-29 Thread Herve Codina
On Thu, 29 Feb 2024 15:58:06 +0200 Andy Shevchenko wrote: > On Thu, Feb 29, 2024 at 01:56:05PM +0100, Herve Codina wrote: > > On Thu, 22 Feb 2024 17:49:40 +0200 > > Andy Shevchenko wrote: > > > On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote: > > ... > > > I've got an issue

Re: [PATCH v4 5/5] net: wan: fsl_qmc_hdlc: Add framer support

2024-02-29 Thread Andy Shevchenko
On Thu, Feb 29, 2024 at 01:56:05PM +0100, Herve Codina wrote: > On Thu, 22 Feb 2024 17:49:40 +0200 > Andy Shevchenko wrote: > > On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote: ... > I've got an issue with guard(spinlock_irqsave). No, you got an issue with sparse. > I have the

Re: [PATCH v4 5/5] net: wan: fsl_qmc_hdlc: Add framer support

2024-02-29 Thread Herve Codina
Hi Andy, On Thu, 22 Feb 2024 17:49:40 +0200 Andy Shevchenko wrote: > On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote: > > Add framer support in the fsl_qmc_hdlc driver in order to be able to > > signal carrier changes to the network stack based on the framer status > > Also use

Re: [PATCH v4 5/5] net: wan: fsl_qmc_hdlc: Add framer support

2024-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote: > Add framer support in the fsl_qmc_hdlc driver in order to be able to > signal carrier changes to the network stack based on the framer status > Also use this framer to provide information related to the E1/T1 line > interface on

[PATCH v4 5/5] net: wan: fsl_qmc_hdlc: Add framer support

2024-02-22 Thread Herve Codina
Add framer support in the fsl_qmc_hdlc driver in order to be able to signal carrier changes to the network stack based on the framer status Also use this framer to provide information related to the E1/T1 line interface on IF_GET_IFACE and configure the line interface according to IF_IFACE_{E1,T1}