Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-09-07 Thread Russell Currey
On Thu, 2022-09-01 at 08:42 -0400, Joe Lawrence wrote: > On Thu, Sep 01, 2022 at 01:39:02PM +1000, Michael Ellerman wrote: > > Joe Lawrence writes: > > > On Thu, Sep 01, 2022 at 08:30:44AM +1000, Michael Ellerman wrote: > > > > Joe Lawrence writes: > > ... > > > > > > Hi Michael, > > > > > >

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-09-01 Thread Song Liu
On Wed, Aug 31, 2022 at 7:05 PM Joe Lawrence wrote: > > On Wed, Aug 31, 2022 at 03:48:26PM -0700, Song Liu wrote: > > On Wed, Aug 31, 2022 at 3:30 PM Michael Ellerman > > wrote: > > > > > > Joe Lawrence writes: > > > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > > > >> From:

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-09-01 Thread Joe Lawrence
On Thu, Sep 01, 2022 at 01:39:02PM +1000, Michael Ellerman wrote: > Joe Lawrence writes: > > On Thu, Sep 01, 2022 at 08:30:44AM +1000, Michael Ellerman wrote: > >> Joe Lawrence writes: > ... > > > > Hi Michael, > > > > While we're on the topic of klp-relocations and Power, I saw a similar > >

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Michael Ellerman
Joe Lawrence writes: > On Thu, Sep 01, 2022 at 08:30:44AM +1000, Michael Ellerman wrote: >> Joe Lawrence writes: ... > > Hi Michael, > > While we're on the topic of klp-relocations and Power, I saw a similar > access problem when writing (late) relocations into > .data..ro_after_init. I'm not

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Thu, Sep 01, 2022 at 08:30:44AM +1000, Michael Ellerman wrote: > Joe Lawrence writes: > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > >> From: Miroslav Benes > >> > >> Josh reported a bug: > >> > >> When the object to be patched is a module, and that module is > >>

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Wed, Aug 31, 2022 at 03:48:26PM -0700, Song Liu wrote: > On Wed, Aug 31, 2022 at 3:30 PM Michael Ellerman wrote: > > > > Joe Lawrence writes: > > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > > >> From: Miroslav Benes > > >> > > >> Josh reported a bug: > > >> > > >> When

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Song Liu
On Wed, Aug 31, 2022 at 3:30 PM Michael Ellerman wrote: > > Joe Lawrence writes: > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > >> From: Miroslav Benes > >> > >> Josh reported a bug: > >> > >> When the object to be patched is a module, and that module is > >> rmmod'ed and

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Michael Ellerman
Joe Lawrence writes: > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: >> From: Miroslav Benes >> >> Josh reported a bug: >> >> When the object to be patched is a module, and that module is >> rmmod'ed and reloaded, it fails to load with: >> >> module: x86/modules: Skipping

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Wed, Aug 31, 2022 at 10:05:43AM -0700, Song Liu wrote: > On Wed, Aug 31, 2022 at 1:01 AM Christophe Leroy > wrote: > > > > > > > > Le 30/08/2022 à 20:53, Song Liu a écrit : > > > From: Miroslav Benes > > > > > > Josh reported a bug: > > > > > >When the object to be patched is a module,

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > From: Miroslav Benes > > Josh reported a bug: > > When the object to be patched is a module, and that module is > rmmod'ed and reloaded, it fails to load with: > > module: x86/modules: Skipping invalid relocation target,

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Christophe Leroy
Le 31/08/2022 à 19:05, Song Liu a écrit : > On Wed, Aug 31, 2022 at 1:01 AM Christophe Leroy > wrote: >> >> >> >> Le 30/08/2022 à 20:53, Song Liu a écrit : >>> From: Miroslav Benes >>> >>> Josh reported a bug: >>> >>> When the object to be patched is a module, and that module is >>>

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Song Liu
On Wed, Aug 31, 2022 at 1:01 AM Christophe Leroy wrote: > > > > Le 30/08/2022 à 20:53, Song Liu a écrit : > > From: Miroslav Benes > > > > Josh reported a bug: > > > >When the object to be patched is a module, and that module is > >rmmod'ed and reloaded, it fails to load with: > > > >

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Christophe Leroy
Le 30/08/2022 à 20:53, Song Liu a écrit : > From: Miroslav Benes > > Josh reported a bug: > >When the object to be patched is a module, and that module is >rmmod'ed and reloaded, it fails to load with: > >module: x86/modules: Skipping invalid relocation target, existing value is

[PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-30 Thread Song Liu
From: Miroslav Benes Josh reported a bug: When the object to be patched is a module, and that module is rmmod'ed and reloaded, it fails to load with: module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 2, loc ba0302e9, val a03e293c