Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote: On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
On Thu, Jan 17, 2013 at 11:14:22AM +0200, Felipe Balbi wrote: On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote: On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we need to use

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 05:28:30PM +0800, Peter Chen wrote: trimming From what I understand balbi's comment, he dislikes this full list of device id. Instead, he prefers to something like below. static const struct platform_device_id fsl_udc_devtype[] = { {

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-15 Thread Shawn Guo
On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly.

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-15 Thread Peter Chen
On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate

[PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly. Signed-off-by: Peter Chen peter.c...@freescale.com ---