Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

2014-12-08 Thread Jiri Olsa
On Sat, Dec 06, 2014 at 11:37:24PM -0800, Sukadev Bhattiprolu wrote: > Jiri Olsa [jo...@redhat.com] wrote: > > | anyway we could assign directly to the param term name as you do, > | but I think we just need to mark the term as parametrized, like: > | > | in /sys/bus/event_source/devices/pmu/even

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

2014-12-06 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | anyway we could assign directly to the param term name as you do, | but I think we just need to mark the term as parametrized, like: | | in /sys/bus/event_source/devices/pmu/events/event_name you have: | param2=?,bar=1,param1=? I like the idea of just usin

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

2014-12-06 Thread Jiri Olsa
On Fri, Dec 05, 2014 at 06:05:26PM -0500, Cody P Schafer wrote: > On Thu, Dec 4, 2014 at 7:44 AM, Jiri Olsa wrote: > > On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote: > >> From: Cody P Schafer > >> > >> Enable event specification like: > >> > >> pmu/event_name,param1=0x

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

2014-12-05 Thread Cody P Schafer
On Thu, Dec 4, 2014 at 7:44 AM, Jiri Olsa wrote: > On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote: >> From: Cody P Schafer >> >> Enable event specification like: >> >> pmu/event_name,param1=0x1,param2=0x4/ >> >> Assuming that >> >> /sys/bus/event_source/devices/pm

Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events

2014-12-04 Thread Jiri Olsa
On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote: > From: Cody P Schafer > > Enable event specification like: > > pmu/event_name,param1=0x1,param2=0x4/ > > Assuming that > > /sys/bus/event_source/devices/pmu/events/event_name > > Contains something like > >

[PATCH v5 1/4] tools/perf: support parsing parameterized events

2014-12-02 Thread Sukadev Bhattiprolu
From: Cody P Schafer Enable event specification like: pmu/event_name,param1=0x1,param2=0x4/ Assuming that /sys/bus/event_source/devices/pmu/events/event_name Contains something like param2=$foo,bar=1,param1=$baz Changelog[v4]: [Jiri Olsa] Merge to recent perf