Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Gavin Shan
On Thu, May 22, 2014 at 07:56:31AM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2014-05-21 at 15:07 +0200, Alexander Graf wrote: > >> > +#ifdef CONFIG_VFIO_PCI_EEH >> > +int eeh_vfio_open(struct pci_dev *pdev) >> >> Why vfio? Also that config option will not be set if vfio is compiled as >> a mo

Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-21 Thread Gavin Shan
On Wed, May 21, 2014 at 03:07:26PM +0200, Alexander Graf wrote: > >On 21.05.14 07:03, Gavin Shan wrote: >>The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device >>to support EEH functionality for PCI devices, which have been >>passed from host to guest via VFIO. >> >>Signed-off-by: Gavin S

Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-21 Thread Benjamin Herrenschmidt
On Wed, 2014-05-21 at 15:07 +0200, Alexander Graf wrote: > > +#ifdef CONFIG_VFIO_PCI_EEH > > +int eeh_vfio_open(struct pci_dev *pdev) > > Why vfio? Also that config option will not be set if vfio is compiled as > a module. > > > +{ > > + struct eeh_dev *edev; > > + > > + /* No PCI device ?

Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-21 Thread Alexander Graf
On 21.05.14 07:03, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan --- Documentation/vfio.txt | 6 +- arch/powerpc/include/

[PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-20 Thread Gavin Shan
The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan --- Documentation/vfio.txt | 6 +- arch/powerpc/include/asm/eeh.h | 10 ++ arch/powerpc/kernel/ee