Re: [PATCH v6] qe: add ability to upload QE firmware

2008-01-08 Thread Timur Tabi
Stephen Rothwell wrote: Why not: const u64 *iprop; int len; iprop = of_get_property(fs, extended-modes, len); if (iprop (len == sizeof(u64)) qe_firmware_info.extended_modes = *iprop; Actually, I like my way better, because then I don't have to

Re: [PATCH v6] qe: add ability to upload QE firmware

2008-01-08 Thread Josh Boyer
On Tue, 08 Jan 2008 09:26:27 -0600 Timur Tabi [EMAIL PROTECTED] wrote: Stephen Rothwell wrote: If you use: for_each_child_of_node(qe, fw) You don't need to initialise 'fw' in its declararion. I can't find for_each_child_of_node. It's not in Kumar's for-2.6.25 branch.

[PATCH v6] qe: add ability to upload QE firmware

2008-01-07 Thread Timur Tabi
Define the layout of a binary blob that contains a QE firmware and instructions on how to upload it. Add function qe_upload_firmware() to parse the blob and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to include the actual RISC Special Registers. Added description of a