[PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-27 Thread Ard Biesheuvel
An ordinary arm64 defconfig build has ~64 KB worth of __ksymtab entries, each consisting of two 64-bit fields containing absolute references, to the symbol itself and to a char array containing its name, respectively. When we build the same configuration with KASLR enabled, we end up with an addit

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-27 Thread Linus Torvalds
On Wed, Dec 27, 2017 at 12:50 AM, Ard Biesheuvel wrote: > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > index 52e611ab9a6c..fe752d365334 100644 > --- a/include/linux/compiler.h > +++ b/include/linux/compiler.h > @@ -327,4 +327,15 @@ static __always_inline void __write_once_siz

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-27 Thread Ard Biesheuvel
On 27 December 2017 at 20:07, Linus Torvalds wrote: > On Wed, Dec 27, 2017 at 12:50 AM, Ard Biesheuvel > wrote: >> diff --git a/include/linux/compiler.h b/include/linux/compiler.h >> index 52e611ab9a6c..fe752d365334 100644 >> --- a/include/linux/compiler.h >> +++ b/include/linux/compiler.h >> @@

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-27 Thread Linus Torvalds
On Wed, Dec 27, 2017 at 12:11 PM, Ard Biesheuvel wrote: > > I tried to keep the generic patches generic, so perhaps I should just > put the arm64 vmlinux.lds.S change in a patch on its own? I guess it doesn't matter, but regardless of where it gets introduced I would like to see the explanation f

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-27 Thread Ard Biesheuvel
On 27 December 2017 at 20:13, Linus Torvalds wrote: > On Wed, Dec 27, 2017 at 12:11 PM, Ard Biesheuvel > wrote: >> >> I tried to keep the generic patches generic, so perhaps I should just >> put the arm64 vmlinux.lds.S change in a patch on its own? > > I guess it doesn't matter, but regardless of

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-28 Thread Ingo Molnar
* Ard Biesheuvel wrote: > Annoyingly, we need this because there is a single instance of a > special section that ends up in the EFI stub code: we build lib/sort.c > again as a EFI libstub object, and given that sort() is exported, we > end up with a ksymtab section in the EFI stub. The sort() t

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-28 Thread Ard Biesheuvel
On 28 December 2017 at 12:05, Ingo Molnar wrote: > > * Ard Biesheuvel wrote: > >> Annoyingly, we need this because there is a single instance of a >> special section that ends up in the EFI stub code: we build lib/sort.c >> again as a EFI libstub object, and given that sort() is exported, we >> e

Re: [PATCH v6 2/8] module: use relative references for __ksymtab entries

2017-12-28 Thread kbuild test robot
Hi Ard, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc5 next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ar