Re: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-19 Thread Stephen Rothwell
On Fri, 19 Oct 2007 08:10:00 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > what's the rule of thumb to know when to include does > everything starting with of_flat_* come from there? Basically anything that deals with the flattened device tee should include asm/prom.h. This may change in the

Re: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-19 Thread Kumar Gala
On Oct 18, 2007, at 7:43 PM, Stephen Rothwell wrote: > On Thu, 18 Oct 2007 23:04:02 +0800 Li Yang <[EMAIL PROTECTED]> > wrote: >> >> +++ b/arch/powerpc/platforms/83xx/mpc837x_mds.c >> +static void __init mpc837x_mds_setup_arch(void) >> +{ >> +#ifdef CONFIG_PCI >> +struct device_node *np; >>

Re: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Stephen Rothwell
On Fri, 19 Oct 2007 11:56:34 +0800 "Li Yang-r58472" <[EMAIL PROTECTED]> wrote: > > is included in now. Do you think it should be > included explicitly? Yes. It may not be included by linux/of.h in the future. (My general opinion is that if you use something, you should explictly include the f

RE: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Li Yang-r58472
> -Original Message- > From: Stephen Rothwell [mailto:[EMAIL PROTECTED] > Sent: Friday, October 19, 2007 8:43 AM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v6 4/9] add platform support

Re: [PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Stephen Rothwell
On Thu, 18 Oct 2007 23:04:02 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/83xx/mpc837x_mds.c > +static void __init mpc837x_mds_setup_arch(void) > +{ > +#ifdef CONFIG_PCI > + struct device_node *np; > +#endif > + > + if (ppc_md.progress) > + ppc_md.pr

[PATCH v6 4/9] add platform support for MPC837x MDS board

2007-10-18 Thread Li Yang
The MPC837x MDS is a new member of Freescale MDS reference system. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/Kconfig | 12 arch/powerpc/platforms/83xx/Makefile |1 + arch/powerpc/platforms/83xx/mpc837x_mds.c | 103 +++