Re: [PATCH v8 4/8] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls

2019-09-18 Thread Bharata B Rao
On Tue, Sep 17, 2019 at 04:35:02PM -0700, Sukadev Bhattiprolu wrote: > > > +unsigned long kvmppc_h_svm_init_done(struct kvm *kvm) > > +{ > > + if (!(kvm->arch.secure_guest & KVMPPC_SECURE_INIT_START)) > > Minor: Should we also check if KVMPPC_SECURE_INIT_DONE is set here (since > both can be

Re: [PATCH v8 4/8] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls

2019-09-17 Thread Sukadev Bhattiprolu
> +unsigned long kvmppc_h_svm_init_done(struct kvm *kvm) > +{ > + if (!(kvm->arch.secure_guest & KVMPPC_SECURE_INIT_START)) Minor: Should we also check if KVMPPC_SECURE_INIT_DONE is set here (since both can be set)?

[PATCH v8 4/8] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls

2019-09-10 Thread Bharata B Rao
H_SVM_INIT_START: Initiate securing a VM H_SVM_INIT_DONE: Conclude securing a VM As part of H_SVM_INIT_START, register all existing memslots with the UV. H_SVM_INIT_DONE call by UV informs HV that transition of the guest to secure mode is complete. These two states (transition to secure mode