Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-23 Thread Jean Delvare
Hi Jochen, Sorry for the late answer. On Thu, 3 Jan 2008 10:41:21 +1100, Stephen Rothwell wrote: Hi Jochen, Just a few trivial things. On Wed, 02 Jan 2008 20:52:00 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: +++ b/drivers/i2c/busses/i2c-cpm.c + +static irqreturn_t

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-23 Thread Jochen Friedrich
Hi Jean, Do you have an updated patch addressing Stephen's comment? Note: you'd rather send updates of this patch to the i2c list rather than LKML. I'm currently looking at that last patches from Jon and try to make this driver fit in there (+ the class override stuff). Note: will do. I

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-23 Thread Jean Delvare
Hallo Jochen, On Wed, 23 Jan 2008 12:23:58 +0100, Jochen Friedrich wrote: Hi Jean, Do you have an updated patch addressing Stephen's comment? Note: you'd rather send updates of this patch to the i2c list rather than LKML. I'm currently looking at that last patches from Jon and try

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-23 Thread Jon Smirl
On 1/23/08, Jean Delvare [EMAIL PROTECTED] wrote: Hallo Jochen, On Wed, 23 Jan 2008 12:23:58 +0100, Jochen Friedrich wrote: Hi Jean, Do you have an updated patch addressing Stephen's comment? Note: you'd rather send updates of this patch to the i2c list rather than LKML. I'm

[PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-02 Thread Jochen Friedrich
Using the port of 2.4 code from Vitaly Bordug [EMAIL PROTECTED] and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to i2c-cpm.c and converted the driver to an of_platform_driver.

Re: [PATCHv2] i2c: adds support for i2c bus on Frescale CPM1/CPM2 controllers

2008-01-02 Thread Stephen Rothwell
Hi Jochen, Just a few trivial things. On Wed, 02 Jan 2008 20:52:00 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: +++ b/drivers/i2c/busses/i2c-cpm.c + +static irqreturn_t cpm_i2c_interrupt(int irq, void *dev_id) +{ + struct i2c_adapter *adap; + struct cpm_i2c *cpm; + struct