Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 10:40 AM, Pingfan Liu wrote: > On Mon, Jul 9, 2018 at 3:48 PM Rafael J. Wysocki wrote: >> >> On Mon, Jul 9, 2018 at 8:48 AM, Pingfan Liu wrote: >> > On Sun, Jul 8, 2018 at 4:25 PM Rafael J. Wysocki wrote: [cut] >> >> I simply think that there should be one way to iterat

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-09 Thread Pingfan Liu
On Mon, Jul 9, 2018 at 3:48 PM Rafael J. Wysocki wrote: > > On Mon, Jul 9, 2018 at 8:48 AM, Pingfan Liu wrote: > > On Sun, Jul 8, 2018 at 4:25 PM Rafael J. Wysocki wrote: > >> > >> On Sat, Jul 7, 2018 at 6:24 AM, Pingfan Liu wrote: > >> > On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: > >>

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 8:48 AM, Pingfan Liu wrote: > On Sun, Jul 8, 2018 at 4:25 PM Rafael J. Wysocki wrote: >> >> On Sat, Jul 7, 2018 at 6:24 AM, Pingfan Liu wrote: >> > On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: >> >> >> >> On Fri, Jul 6, 2018 at 4:47 PM Rafael J. Wysocki >> >> wrote

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-08 Thread Pingfan Liu
On Sun, Jul 8, 2018 at 4:25 PM Rafael J. Wysocki wrote: > > On Sat, Jul 7, 2018 at 6:24 AM, Pingfan Liu wrote: > > On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: > >> > >> On Fri, Jul 6, 2018 at 4:47 PM Rafael J. Wysocki wrote: > >> > > >> > On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wro

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-08 Thread Rafael J. Wysocki
On Sat, Jul 7, 2018 at 6:24 AM, Pingfan Liu wrote: > On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: >> >> On Fri, Jul 6, 2018 at 4:47 PM Rafael J. Wysocki wrote: >> > >> > On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wrote: >> > > [cc += Kishon Vijay Abraham] >> > > >> > > On Thu, Jul 05, 2

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-06 Thread Pingfan Liu
On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: > > On Fri, Jul 6, 2018 at 4:47 PM Rafael J. Wysocki wrote: > > > > On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wrote: > > > [cc += Kishon Vijay Abraham] > > > > > > On Thu, Jul 05, 2018 at 11:18:28AM +0200, Rafael J. Wysocki wrote: > > >> OK,

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-06 Thread Pingfan Liu
On Fri, Jul 6, 2018 at 4:47 PM Rafael J. Wysocki wrote: > > On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wrote: > > [cc += Kishon Vijay Abraham] > > > > On Thu, Jul 05, 2018 at 11:18:28AM +0200, Rafael J. Wysocki wrote: > >> OK, so calling devices_kset_move_last() from really_probe() clearly is

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-06 Thread Pingfan Liu
On Fri, Jul 6, 2018 at 4:36 PM Lukas Wunner wrote: > > [cc += Kishon Vijay Abraham] > > On Thu, Jul 05, 2018 at 11:18:28AM +0200, Rafael J. Wysocki wrote: > > OK, so calling devices_kset_move_last() from really_probe() clearly is > > a mistake. > > > > I'm not really sure what the intention of it

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-06 Thread Kishon Vijay Abraham I
+Grygorii, linux-omap On Friday 06 July 2018 02:06 PM, Lukas Wunner wrote: > [cc += Kishon Vijay Abraham] > > On Thu, Jul 05, 2018 at 11:18:28AM +0200, Rafael J. Wysocki wrote: >> OK, so calling devices_kset_move_last() from really_probe() clearly is >> a mistake. >> >> I'm not really sure what t

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-06 Thread Rafael J. Wysocki
On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wrote: > [cc += Kishon Vijay Abraham] > > On Thu, Jul 05, 2018 at 11:18:28AM +0200, Rafael J. Wysocki wrote: >> OK, so calling devices_kset_move_last() from really_probe() clearly is >> a mistake. >> >> I'm not really sure what the intention of it was

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-05 Thread Rafael J. Wysocki
On Thu, Jul 5, 2018 at 4:44 AM, Pingfan Liu wrote: > On Wed, Jul 4, 2018 at 6:23 PM Rafael J. Wysocki wrote: >> >> On Wednesday, July 4, 2018 4:47:07 AM CEST Pingfan Liu wrote: >> > On Tue, Jul 3, 2018 at 10:36 PM Rafael J. Wysocki >> > wrote: >> > > >> > > On Tuesday, July 3, 2018 8:50:38 AM C

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-04 Thread Pingfan Liu
On Wed, Jul 4, 2018 at 6:23 PM Rafael J. Wysocki wrote: > > On Wednesday, July 4, 2018 4:47:07 AM CEST Pingfan Liu wrote: > > On Tue, Jul 3, 2018 at 10:36 PM Rafael J. Wysocki > > wrote: > > > > > > On Tuesday, July 3, 2018 8:50:38 AM CEST Pingfan Liu wrote: > > > > commit 52cdbdd49853 ("driver

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-04 Thread Rafael J. Wysocki
On Wednesday, July 4, 2018 4:47:07 AM CEST Pingfan Liu wrote: > On Tue, Jul 3, 2018 at 10:36 PM Rafael J. Wysocki wrote: > > > > On Tuesday, July 3, 2018 8:50:38 AM CEST Pingfan Liu wrote: > > > commit 52cdbdd49853 ("driver core: correct device's shutdown order") > > > places an assumption of supp

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-03 Thread Pingfan Liu
On Tue, Jul 3, 2018 at 10:36 PM Rafael J. Wysocki wrote: > > On Tuesday, July 3, 2018 8:50:38 AM CEST Pingfan Liu wrote: > > commit 52cdbdd49853 ("driver core: correct device's shutdown order") > > places an assumption of supplier<-consumer order on the process of probe. > > But it turns out to br

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-03 Thread Rafael J. Wysocki
On Tuesday, July 3, 2018 8:50:38 AM CEST Pingfan Liu wrote: > commit 52cdbdd49853 ("driver core: correct device's shutdown order") > places an assumption of supplier<-consumer order on the process of probe. > But it turns out to break down the parent <- child order in some scene. > E.g in pci, a br

[PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-02 Thread Pingfan Liu
commit 52cdbdd49853 ("driver core: correct device's shutdown order") places an assumption of supplier<-consumer order on the process of probe. But it turns out to break down the parent <- child order in some scene. E.g in pci, a bridge is enabled by pci core, and behind it, the devices have been pr