Re: [Patch] NULL pointer deref with corrupted squashfs image

2009-01-21 Thread Phillip Lougher
Eric Sesterhenn wrote: Some callers of zlib_inflate() might accidentally pass a NULL pointer in strm->next_out which zlib_inflate() should catch. Others like the powerpc gunzip_partial expect to be able to extract a zImage to memory location 0. This introduces zlib_inflate_usafe() for those and

Re: [Patch] NULL pointer deref with corrupted squashfs image

2009-01-21 Thread Eric Sesterhenn
* Tom Rini (tr...@kernel.crashing.org) wrote: > On Tue, Jan 20, 2009 at 05:47:14PM +0100, Eric Sesterhenn wrote: > > * Jörn Engel (jo...@logfs.org) wrote: > > > On Fri, 16 January 2009 16:07:00 -0700, Tom Rini wrote: > > > > > > > > Sounds like a plan to me, except maybe zlib_inflate_unsafe() and

Re: [Patch] NULL pointer deref with corrupted squashfs image

2009-01-20 Thread Tom Rini
On Tue, Jan 20, 2009 at 05:47:14PM +0100, Eric Sesterhenn wrote: > * Jörn Engel (jo...@logfs.org) wrote: > > On Fri, 16 January 2009 16:07:00 -0700, Tom Rini wrote: > > > > > > Sounds like a plan to me, except maybe zlib_inflate_unsafe() and a > > > comment above the wrapper saying what/why is goi

Re: [Patch] NULL pointer deref with corrupted squashfs image

2009-01-20 Thread Jörn Engel
On Tue, 20 January 2009 17:47:14 +0100, Eric Sesterhenn wrote: > > Some callees of zlib_inflate() might accidentally pass a NULL s/callee/caller/ ? Apart from this, looks fine to me - modulo xtensa of course. Jörn -- Sometimes, asking the right question is already the answer. -- Unknown _

Re: [Patch] NULL pointer deref with corrupted squashfs image

2009-01-20 Thread Eric Sesterhenn
* Jörn Engel (jo...@logfs.org) wrote: > On Fri, 16 January 2009 16:07:00 -0700, Tom Rini wrote: > > > > Sounds like a plan to me, except maybe zlib_inflate_unsafe() and a > > comment above the wrapper saying what/why is going on? > > Eric, will you do the honors? Since you did all the hard work